Return-Path: 
 <dev-return-39496-apmail-activemq-dev-archive=activemq.apache.org@activemq.apache.org>
X-Original-To: apmail-activemq-dev-archive@www.apache.org
Delivered-To: apmail-activemq-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 9A43C10BC6
	for <apmail-activemq-dev-archive@www.apache.org>;
 Mon, 22 Jul 2013 12:14:56 +0000 (UTC)
Received: (qmail 3627 invoked by uid 500); 22 Jul 2013 12:14:55 -0000
Delivered-To: apmail-activemq-dev-archive@activemq.apache.org
Received: (qmail 3382 invoked by uid 500); 22 Jul 2013 12:14:51 -0000
Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@activemq.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@activemq.apache.org>
List-Post: <mailto:dev@activemq.apache.org>
List-Id: <dev.activemq.apache.org>
Reply-To: dev@activemq.apache.org
Delivered-To: mailing list dev@activemq.apache.org
Received: (qmail 3290 invoked by uid 99); 22 Jul 2013 12:14:48 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 22 Jul 2013 12:14:48 +0000
Date: Mon, 22 Jul 2013 12:14:48 +0000 (UTC)
From: "Gary Tully (JIRA)" <jira@apache.org>
To: dev@activemq.apache.org
Message-ID: <JIRA.12658817.1374263203136.90156.1374495288531@arcas>
In-Reply-To: <JIRA.12658817.1374263203136@arcas>
References: <JIRA.12658817.1374263203136@arcas>
Subject: [jira] [Resolved] (AMQ-4645) The lease-database-locker does not
 work properly slave broker ssytem clock is behind Database server
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


     [ https://issues.apache.org/jira/browse/AMQ-4645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gary Tully resolved AMQ-4645.
-----------------------------

    Resolution: Fixed

diff now applied correctly. Additional tests to validate
                
> The lease-database-locker does not work properly slave broker ssytem clock is behind Database server
> ----------------------------------------------------------------------------------------------------
>
>                 Key: AMQ-4645
>                 URL: https://issues.apache.org/jira/browse/AMQ-4645
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: Message Store
>    Affects Versions: 5.8.0
>         Environment: jdbc master slave
>            Reporter: Gary Tully
>            Assignee: Gary Tully
>              Labels: clock, jdbc, lease, masterSlave
>             Fix For: 5.9.0
>
>
> The lease locker can adjust the lease duration based on the DB current time but this only works if the broker is ahead of the Db.
> If the broker is behind, it will always obtain a lease due to incorrect adjustment.
> If the clocks are in sync there is no issue.{code}
> <persistenceAdapter>
>         <jdbcPersistenceAdapter dataSource="#oracle-ds" lockKeepAlivePeriod="5000">
>             <locker>
>                 <lease-database-locker lockAcquireSleepInterval="10000"/>
>             </locker>
>         </jdbcPersistenceAdapter>
>     </persistenceAdapter>{code}
> The problem is that the negative diff is being treated as a positive diff.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira