Return-Path: X-Original-To: apmail-activemq-dev-archive@www.apache.org Delivered-To: apmail-activemq-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 579ECCE50 for ; Tue, 16 Jul 2013 18:42:56 +0000 (UTC) Received: (qmail 7866 invoked by uid 500); 16 Jul 2013 18:42:55 -0000 Delivered-To: apmail-activemq-dev-archive@activemq.apache.org Received: (qmail 7541 invoked by uid 500); 16 Jul 2013 18:42:54 -0000 Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@activemq.apache.org Delivered-To: mailing list dev@activemq.apache.org Received: (qmail 6825 invoked by uid 99); 16 Jul 2013 18:42:52 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 16 Jul 2013 18:42:52 +0000 Date: Tue, 16 Jul 2013 18:42:52 +0000 (UTC) From: "Timothy Bish (JIRA)" To: dev@activemq.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (AMQ-4582) Specifying invalid ciphersuite in SSL transport causes all available ciphersuites to be enabled MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/AMQ-4582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13710067#comment-13710067 ] Timothy Bish commented on AMQ-4582: ----------------------------------- Might need to dig in deeper here since this breaks many unit tests in activemq-unit-tests > Specifying invalid ciphersuite in SSL transport causes all available ciphersuites to be enabled > ----------------------------------------------------------------------------------------------- > > Key: AMQ-4582 > URL: https://issues.apache.org/jira/browse/AMQ-4582 > Project: ActiveMQ > Issue Type: Bug > Components: Broker > Affects Versions: 5.8.0 > Environment: Linux 3.2.0-41-generic x86_64 > Reporter: Robert Huffman > Labels: security, ssl > Attachments: AMQ-4582.patch > > > If you use an invalid cipher suite in the parameter "transport.enabledCipherSuites" on an SSL transport connector, the broker will start with all ciphers enabled. > For example, use this transport connector: > > > > This is an attempt to enable the ciphersuite "foobar". The broker starts, and, in my environment I end up with 26 cipher suites enabled, 10 of which are generally considered weak. > Using the debugger I tracked this down to the method org.apache.activemq.util.IntrospectionSupport.setProperty. It uses reflection to invoke SSLServerSocket.setEnabledCipherSuites. That method throws an IllegalArgumentException if the specified ciphersuite is enabled. IntrospectionSupport.setProperty catches the exception and returns false. > I believe that this code should not be ignoring exceptions like this. This is a major security flaw: if a user is attempting to lock down ActiveMQ to a specific strong cipher suite, but makes a typo, the broker starts with with the ability to use weaker cipher suites. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira