activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rafael Alfaro (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (AMQ-4591) org.apache.activemq.broker.scheduler.CronParser bug on getNextScheduledTime() to handle the once per minute case "* * * * *"
Date Thu, 20 Jun 2013 07:13:21 GMT

     [ https://issues.apache.org/jira/browse/AMQ-4591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Rafael Alfaro updated AMQ-4591:
-------------------------------

    Description: 
There is a Bug on handle the once per minute case.
For the cronentry: "* * * * *" 
The Next Scheduled time is not the top of the next minute.
Instead, is the current Time plus 60 seconds

The problem is that the code is trying to set the precision at seconds, but the precision
must have to be at minutes. 

You can check the patch attached to see the change required to fix this issue.

  was:
There is a Bug on handle the once per minute case.
For the cronentry: "* * * * *" 
The Next Scheduled time is not the top of the next minute.
Instead, is the current Time plus 60 seconds

The problem is that the code is trying to set the precision at seconds, but the precision
must have to be at minutes. 
It can be fixed in this way:

Index: activemq-client/src/main/java/org/apache/activemq/broker/scheduler/CronParser.java
===================================================================
--- activemq-client/src/main/java/org/apache/activemq/broker/scheduler/CronParser.java	(revision
1494862)
+++ activemq-client/src/main/java/org/apache/activemq/broker/scheduler/CronParser.java	(working
copy)
@@ -44,7 +44,7 @@
         // starting the next event at the top of the minute.
         if (cronEntry.equals("* * * * *")) {
             result = currentTime + 60 * 1000;
-            result = result / 1000 * 1000;
+            result = result / 60000 * 60000;
             return result;
         }


    
> org.apache.activemq.broker.scheduler.CronParser bug on getNextScheduledTime() to handle
the once per minute case "* * * * *"
> ----------------------------------------------------------------------------------------------------------------------------
>
>                 Key: AMQ-4591
>                 URL: https://issues.apache.org/jira/browse/AMQ-4591
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 5.8.0, 5.9.0
>         Environment: Any
>            Reporter: Rafael Alfaro
>              Labels: patch
>         Attachments: CronParser.java.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> There is a Bug on handle the once per minute case.
> For the cronentry: "* * * * *" 
> The Next Scheduled time is not the top of the next minute.
> Instead, is the current Time plus 60 seconds
> The problem is that the code is trying to set the precision at seconds, but the precision
must have to be at minutes. 
> You can check the patch attached to see the change required to fix this issue.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message