Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@activemq.apache.org
Date: Mon, 13 May 2013 19:49:16 +0000 (UTC)
From: "Timothy Bish (JIRA)" <jira@apache.org>
To: dev@activemq.apache.org
Message-ID: <JIRA.12642198.1365750342481.311228.1368474556042@arcas>
In-Reply-To: <JIRA.12642198.1365750342481@arcas>
References: <JIRA.12642198.1365750342481@arcas>
Subject: [jira] [Commented] (AMQ-4468) TimeStampPlugin doesn't work with
 Stomp
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/AMQ-4468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13656287#comment-13656287 ] 

Timothy Bish commented on AMQ-4468:
-----------------------------------

Seems to be working as expected.  If you can provide a test that shows something wrong please do. 
                
> TimeStampPlugin doesn't work with Stomp
> ---------------------------------------
>
>                 Key: AMQ-4468
>                 URL: https://issues.apache.org/jira/browse/AMQ-4468
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: stomp
>    Affects Versions: 5.8.0
>         Environment: Ubuntu 12.04.1 LTS Precise, OpenJDK Runtime Environment (IcedTea7 2.3.3) (7u9-2.3.3-0ubuntu1~12.04.1)
>            Reporter: Erik
>            Assignee: Timothy Bish
>            Priority: Minor
>              Labels: JMSExpiration, JMSExpires, JMSTimestamp, TimeStampPlugin, activemq, disableTimeStampsByDefault, expires, stomp, timestamp
>         Attachments: StompTimeStampingBrokerPluginTest.java
>
>
> Stomp producers cannot set the JMSTimestamp or timestamp header. Activemq always adds a timestamp header and overrides a set value. Therefore, the expires header cannot be recalculated according to Activemq time according to the description for TimeStampPlugin. TimeStampPlugin works for JMS producers because the JMSExpiration UTC can be adjusted up/down according to the difference between JMSTimestamp and Activemq UTC.
> Example:
> ActiveMQ time is 2pm UTC
> Stomp producer time is 1:03pm UTC.
> Stomp expires time is 1:03pm + 15 minutes: 1:18pm UTC.
> ActiveMQ will throw this message away with TimeStampPlugin enabled.
> ActiveMQ will deliver this message for a JMSProducer.
> Recommendation:
> 1)
> ActiveMQ should allow Stomp producers to set a timestamp or JMSTimestamp header.
> if( Stomp Message Timestamp Header ) {
> use header
> }
> else {
> add timestamp header
> }
> 2)
> Add the disableTimeStampsByDefault=true feature to the stomp protocol URI.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira