Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@activemq.apache.org
Date: Mon, 6 May 2013 11:04:17 +0000 (UTC)
From: "Erik Bunn (JIRA)" <jira@apache.org>
To: dev@activemq.apache.org
Message-ID: <JIRA.12640319.1364914635935.272966.1367838257408@arcas>
In-Reply-To: <JIRA.12640319.1364914635935@arcas>
References: <JIRA.12640319.1364914635935@arcas>
Subject: [jira] [Commented] (AMQ-4428) Don't swallow errors in
 IntrospectionSupport.setProperty
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/AMQ-4428?page=3Dcom.atlassian.j=
ira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D136496=
49#comment-13649649 ]=20

Erik Bunn commented on AMQ-4428:
--------------------------------

An example of where this swallowed Throwable produced considerable headache=
.

An embedded Broker's timeout options were not being set as expected. The fi=
rst suspect was documentation wiki/code mismatch (FailoverTransport backoff=
Multiplier vs. reconnectDelayExponent), but this wasn't the real culprit: I=
ntrospectionSupport has a static init of a third-party library, which had b=
een missed by us while minimizing libraries for the embed. The Introspectio=
nSupport.setProperty() catch silently swallows the informative exception.

I would second #2, above.=20
Further, I would suggest catching qualified exceptions rather than Throwabl=
e, which risks silencing possible fatal errors (OOM).=20


               =20
> Don't swallow errors in IntrospectionSupport.setProperty
> --------------------------------------------------------
>
>                 Key: AMQ-4428
>                 URL: https://issues.apache.org/jira/browse/AMQ-4428
>             Project: ActiveMQ
>          Issue Type: Bug
>            Reporter: Christoffer Sawicki
>            Priority: Minor
>         Attachments: 0001-Log-errors-in-IntrospectionSupport.setProperty.=
patch
>
>
> `setProperty` currently ends with `=E2=80=A6 catch (Throwable ignore) \{ =
return false; \}`. This can make troubleshooting invalid configuration much=
 harder since the exception (that contains detailed information) is hidden =
from the user.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrato=
rs
For more information on JIRA, see: http://www.atlassian.com/software/jira