activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christoffer Sawicki (JIRA)" <>
Subject [jira] [Commented] (AMQ-4428) Don't swallow errors in IntrospectionSupport.setProperty
Date Mon, 06 May 2013 20:20:16 GMT


Christoffer Sawicki commented on AMQ-4428:

> Further, I would suggest catching qualified exceptions rather than Throwable [...]

I agree. Here's a {{s/Throwable/Exception/}} patch:

And here's an updated version of the original patch:

(Remove .patch from URL for a prettier view.)

I have run the full ActiveMQ test suite with these changes and they generate no spurious log
> Don't swallow errors in IntrospectionSupport.setProperty
> --------------------------------------------------------
>                 Key: AMQ-4428
>                 URL:
>             Project: ActiveMQ
>          Issue Type: Bug
>            Reporter: Christoffer Sawicki
>            Priority: Minor
> `setProperty` currently ends with `… catch (Throwable ignore) \{ return false; \}`.
This can make troubleshooting invalid configuration much harder since the exception (that
contains detailed information) is hidden from the user.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

View raw message