activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christoffer Sawicki (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AMQ-4428) Don't swallow errors in IntrospectionSupport.setProperty
Date Mon, 06 May 2013 20:20:16 GMT

    [ https://issues.apache.org/jira/browse/AMQ-4428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13650069#comment-13650069
] 

Christoffer Sawicki commented on AMQ-4428:
------------------------------------------

> Further, I would suggest catching qualified exceptions rather than Throwable [...]

I agree. Here's a {{s/Throwable/Exception/}} patch:
https://github.com/qerub/activemq/commit/0e09f1649a4cecb38476262a61f51acf578f64e3.patch

And here's an updated version of the original patch:
https://github.com/qerub/activemq/commit/2442b3311e7f069b93a619dd3a8821571d1d67b6.patch

(Remove .patch from URL for a prettier view.)

I have run the full ActiveMQ test suite with these changes and they generate no spurious log
messages.
                
> Don't swallow errors in IntrospectionSupport.setProperty
> --------------------------------------------------------
>
>                 Key: AMQ-4428
>                 URL: https://issues.apache.org/jira/browse/AMQ-4428
>             Project: ActiveMQ
>          Issue Type: Bug
>            Reporter: Christoffer Sawicki
>            Priority: Minor
>
> `setProperty` currently ends with `… catch (Throwable ignore) \{ return false; \}`.
This can make troubleshooting invalid configuration much harder since the exception (that
contains detailed information) is hidden from the user.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message