activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Timothy Bish (JIRA)" <>
Subject [jira] [Commented] (AMQ-4441) Race condition in PooledConnectionFactory.createConnection
Date Fri, 05 Apr 2013 13:48:16 GMT


Timothy Bish commented on AMQ-4441:

Recommend you try and create a test case so this can be validated.
> Race condition in PooledConnectionFactory.createConnection
> ----------------------------------------------------------
>                 Key: AMQ-4441
>                 URL:
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: activemq-pool
>    Affects Versions: 5.8.0
>            Reporter: Andrei N.Sobchuck
> `PooledConnectionFactory.createConnection(String userName, String password)` can return
broken Connection. By `broken` I mean PooledConnection with referenceCount==1, but without
underlying ActiveMQConnection.
> The problem is in lines 
> {code}
> connection = connectionsPool.borrowObject(key);
> ...
> return new PooledConnection(connection);
> {code}
> While method `borrowObject` validates the connection and `new PooledConnection` increments
referenceCount, it's possible that some thread calls `ConnectionPool.decrementReferenceCount()`
just between `borrowObject` and `new PooledConnection`. referenceCount at this stage can be
a zero and the ConnectionPool became closed just prior to `new PooledConnection`.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

View raw message