activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christoffer Sawicki (JIRA)" <j...@apache.org>
Subject [jira] [Created] (AMQ-4433) Socket parameters are not validated
Date Wed, 03 Apr 2013 11:17:15 GMT
Christoffer Sawicki created AMQ-4433:
----------------------------------------

             Summary: Socket parameters are not validated
                 Key: AMQ-4433
                 URL: https://issues.apache.org/jira/browse/AMQ-4433
             Project: ActiveMQ
          Issue Type: Bug
            Reporter: Christoffer Sawicki
            Priority: Minor


Connect parameters are validated in every transport factory with a statement like this:

{noformat}
if (!options.isEmpty()) {
  throw new IllegalArgumentException("Invalid connect parameters: " + options);
}
{noformat}

Socket parameters (i.e. connect parameters prefixed with {{socket.}}) are however never validated.

They are put away at

{noformat}
SslTransportFactory(TcpTransportFactory).compositeConfigure(Transport, WireFormat, Map) line:
85	
{noformat}

and then set at

{noformat}
SslTransport(TcpTransport).initialiseSocket(Socket) line: 428
{noformat}

where there is no check that {{socketOptions}} is empty after the call.

I've attached a patch that rectifies this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message