activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gary Tully (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AMQ-4428) Don't swallow errors in IntrospectionSupport.setProperty
Date Wed, 03 Apr 2013 21:13:16 GMT

    [ https://issues.apache.org/jira/browse/AMQ-4428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13621328#comment-13621328
] 

Gary Tully commented on AMQ-4428:
---------------------------------

I recall there are a few places where url params are applied to a bunch of components in a
chain, the ones that match are removed and there is an assertion that all are consumed. So
in that case, some are expected to be invalid. In that case, using info in place of error
may be better.

A sanity check woud be to run the unit tests in activemq-unit-tests module (mvn test) and
peek at the resulting target/activemq-test.log to see how often the error shows up.
                
> Don't swallow errors in IntrospectionSupport.setProperty
> --------------------------------------------------------
>
>                 Key: AMQ-4428
>                 URL: https://issues.apache.org/jira/browse/AMQ-4428
>             Project: ActiveMQ
>          Issue Type: Bug
>            Reporter: Christoffer Sawicki
>            Priority: Minor
>         Attachments: 0001-Log-errors-in-IntrospectionSupport.setProperty.patch
>
>
> `setProperty` currently ends with `… catch (Throwable ignore) \{ return false; \}`.
This is really evil since it can make ActiveMQ ignore invalid configuration completely silently.
I think that errors should at least be logged. (Is there any case when this isn't wanted?)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message