Return-Path: X-Original-To: apmail-activemq-dev-archive@www.apache.org Delivered-To: apmail-activemq-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id AAC91DEEE for ; Fri, 18 Jan 2013 21:10:13 +0000 (UTC) Received: (qmail 44387 invoked by uid 500); 18 Jan 2013 21:10:13 -0000 Delivered-To: apmail-activemq-dev-archive@activemq.apache.org Received: (qmail 44316 invoked by uid 500); 18 Jan 2013 21:10:12 -0000 Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@activemq.apache.org Delivered-To: mailing list dev@activemq.apache.org Received: (qmail 44144 invoked by uid 99); 18 Jan 2013 21:10:12 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 18 Jan 2013 21:10:12 +0000 Date: Fri, 18 Jan 2013 21:10:12 +0000 (UTC) From: "Timothy Bish (JIRA)" To: dev@activemq.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (AMQ-4082) Refactor network bridge start/stop to reduce async tasks and synchronisation - it is way to complicated atm MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/AMQ-4082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13557604#comment-13557604 ] Timothy Bish commented on AMQ-4082: ----------------------------------- @Gary, have a peak at the current patch. It simplifies the start logic a good bit and the test failures I was seeing are there regardless, seems there's some random failures related to the races in temp dests and consumers on the bridges. > Refactor network bridge start/stop to reduce async tasks and synchronisation - it is way to complicated atm > ----------------------------------------------------------------------------------------------------------- > > Key: AMQ-4082 > URL: https://issues.apache.org/jira/browse/AMQ-4082 > Project: ActiveMQ > Issue Type: Improvement > Components: Broker > Reporter: Gary Tully > Fix For: 5.8.0 > > Attachments: AMQ4082Patch.txt, AMQ4082Patch.txt, AMQ4082Patch.txt, AMQ4082Patch.txt, AMQ4082Patch.txt > > > sequence of events on a start is way to random as a result of many async tasks. > It should/could be very simple. > start remote transport > wait for remote broker info > start local transport and local bridge > start remote bridge > it is all or nothing w.r.t to success or failure. > we have sufficient tests in place to safely do the refactor at this stage. > There have been many bugs in this area and there are still some outstanding > https://issues.apache.org/jira/browse/AMQ-3993 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira