activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Timothy Bish (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AMQ-4241) ActiveMQOutputStream shoud reserve the user property only once
Date Thu, 03 Jan 2013 19:52:13 GMT

    [ https://issues.apache.org/jira/browse/AMQ-4241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13543230#comment-13543230
] 

Timothy Bish commented on AMQ-4241:
-----------------------------------

The patch doesn't include any tests to show why the patch is necessary, should include some
test to show what the original problem is since you state that there is a dangerous method.
                
> ActiveMQOutputStream shoud reserve the user property only once
> --------------------------------------------------------------
>
>                 Key: AMQ-4241
>                 URL: https://issues.apache.org/jira/browse/AMQ-4241
>             Project: ActiveMQ
>          Issue Type: Improvement
>          Components: Broker
>    Affects Versions: 5.5.1, 5.6.0, 5.7.0
>            Reporter: SuoNayi
>            Priority: Trivial
>              Labels: JMSStream
>             Fix For: 5.8.0
>
>         Attachments: AMQ-4241.patch
>
>   Original Estimate: 1m
>  Remaining Estimate: 1m
>
> ActiveMQOutputStream should only reserve the properties from the end user 
> by the first message instead of reserving the properties by every message under the hood.
> While ActiveMQInputStream can obtain those properties by the first incoming message.
> By the way, the exposed call of the receive method to the end user is dangerous because
> the user call on the receive method will cause the data the user received is not the
> whole. The payload of the message that the call returns is lost because it's out of the
> underlying stream.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message