activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christian Posta (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AMQ-4209) NetworkConnector and NetworkBridgeConfiguration have same named private variables for excludedDestination
Date Thu, 06 Dec 2012 17:57:09 GMT

    [ https://issues.apache.org/jira/browse/AMQ-4209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13511563#comment-13511563
] 

Christian Posta commented on AMQ-4209:
--------------------------------------

Seems for excludedDestinations, there are no cases where the method resolution order causes
anything to fail.. but it's just waiting to happen.

However, not only excludedDestination is duplicated in the class hierarchy. So are dynamicallyIncludedDestinations
and staticallyIncludedDestinations. DynamicallyIncludedDestinations being repeated *DOES*
cause a bug. I will write a test case for that (in the process). 

I will remove this duplication as it's just waiting for more bugs.
                
> NetworkConnector and NetworkBridgeConfiguration have same named private variables for
excludedDestination
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: AMQ-4209
>                 URL: https://issues.apache.org/jira/browse/AMQ-4209
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 5.7.0
>            Reporter: Christian Posta
>            Assignee: Christian Posta
>
> NetworkConnector extends from NetworkBridgeConfiguration. Both NetworkConnector and NetworkBridgeConfiguration
have private fields named "private List<ActiveMQDestination> excludedDestinations" Not
only is it confusing which list ends up being used to configure the bridge, but duplex connectors
could have a bug because of this. I'll write a test to reproduce.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message