Return-Path: X-Original-To: apmail-activemq-dev-archive@www.apache.org Delivered-To: apmail-activemq-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3A74CD7EA for ; Mon, 26 Nov 2012 22:49:00 +0000 (UTC) Received: (qmail 43103 invoked by uid 500); 26 Nov 2012 22:48:58 -0000 Delivered-To: apmail-activemq-dev-archive@activemq.apache.org Received: (qmail 43036 invoked by uid 500); 26 Nov 2012 22:48:58 -0000 Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@activemq.apache.org Delivered-To: mailing list dev@activemq.apache.org Received: (qmail 42873 invoked by uid 99); 26 Nov 2012 22:48:58 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 26 Nov 2012 22:48:58 +0000 Date: Mon, 26 Nov 2012 22:48:58 +0000 (UTC) From: "Christian Posta (JIRA)" To: dev@activemq.apache.org Message-ID: <799693110.25056.1353970138390.JavaMail.jiratomcat@arcas> Subject: [jira] [Created] (AMQ-4190) Figure out what was intended with transactions and producer flow control for topics MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 Christian Posta created AMQ-4190: ------------------------------------ Summary: Figure out what was intended with transactions and producer flow control for topics Key: AMQ-4190 URL: https://issues.apache.org/jira/browse/AMQ-4190 Project: ActiveMQ Issue Type: Improvement Components: Broker Reporter: Christian Posta Priority: Minor in Topic#send it checks to see whether memory is full, whether producer flow control is enabled, and whether it should just block the producer, or block the connection. In the "else" clause on line 389, it will block the connection waiting for space. It tries to do something different if the context is in a transaction.. but what it's trying to do is not clear. It looks like it will do exactly the same thing as it would do if it would not be in a transaction. The extra code around (count > 2) doesn't seem like it will ever hit and the log message will never print. Maybe someone was adding functionality there, but didn't finish? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira