activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christian Posta (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AMQ-4123) Improve MQTT Inactivity Monitoring
Date Tue, 23 Oct 2012 22:56:15 GMT

    [ https://issues.apache.org/jira/browse/AMQ-4123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13482777#comment-13482777
] 

Christian Posta commented on AMQ-4123:
--------------------------------------

So I went without the KeepAliveInfo object. 

Also fixed the MQTTTests that were broken, added more around inactivity monitor, added default
keep-alive for server side, implemented a grace-period for keep-alive.

Tim, if you could review just to sanity check, that would be great.

The tests around inactivity monitor are not the best (uses some Thread.sleep() calls to get
the inactivity monitor to hang). If you can think of a better way, I'm all ears.
                
> Improve MQTT Inactivity Monitoring
> ----------------------------------
>
>                 Key: AMQ-4123
>                 URL: https://issues.apache.org/jira/browse/AMQ-4123
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: MQTT, Transport
>    Affects Versions: 5.7.0
>            Reporter: Christian Posta
>            Priority: Minor
>             Fix For: 5.8.0
>
>
> * Keep Alive should be 1.5 * the keep alive value specified by client (the grace period
described in spec: http://public.dhe.ibm.com/software/dw/webservices/ws-mqtt/mqtt-v3r1.html)
> * MQTTInactivityMonitor checking for KeepAliveInfo in the onCommand, but it can never
get a KeepAliveInfo as it is
> * What to do when user explicitly turns Inactivity Monitor off?
> * Should there be defaults to close potentially dead connections?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message