Return-Path: X-Original-To: apmail-activemq-dev-archive@www.apache.org Delivered-To: apmail-activemq-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3AE2FDF08 for ; Tue, 25 Sep 2012 21:26:24 +0000 (UTC) Received: (qmail 71940 invoked by uid 500); 25 Sep 2012 21:26:24 -0000 Delivered-To: apmail-activemq-dev-archive@activemq.apache.org Received: (qmail 71914 invoked by uid 500); 25 Sep 2012 21:26:23 -0000 Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@activemq.apache.org Delivered-To: mailing list dev@activemq.apache.org Received: (qmail 71904 invoked by uid 99); 25 Sep 2012 21:26:23 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 25 Sep 2012 21:26:23 +0000 X-ASF-Spam-Status: No, hits=1.5 required=5.0 tests=HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of e.semog@gmail.com designates 209.85.223.171 as permitted sender) Received: from [209.85.223.171] (HELO mail-ie0-f171.google.com) (209.85.223.171) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 25 Sep 2012 21:26:19 +0000 Received: by iecs9 with SMTP id s9so11266357iec.2 for ; Tue, 25 Sep 2012 14:25:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=N9AkSD3nce2e1qwg0sRfsy/O/AsAVNweCd4ImXl5RP0=; b=n3bIgec4vabKBgLqhviuRPr5GVHA1TE8pq+VmOOZsF1Z+a34l34RTTHCmUSBHTwlYG anV666xPMH9LmKIbmXrwS5/zO6yMn/MvDbp4E9pJoV9agCvpoqDQp3s8/QZTsCFxj5X4 8LrtlNlUuChUt0xTdtNjLYQw2l2Kr33/45GNzG6r+xM+B6GxLskQElKkYfASCKwgx6zD 4Jjm4y8iWpuKSAlg9jkYWfeT0ZwccK6ojzhnMeOm+t6lcxcWGvbuKH8ywo+OKsY3caeQ R20qDm0P2lenuBMJFp3dImlm4vFEUhRxu/pktQgSAtKdKuBjPECTmkXr3T25zA7rtT4z wvfQ== MIME-Version: 1.0 Received: by 10.50.152.243 with SMTP id vb19mr9542943igb.4.1348608358524; Tue, 25 Sep 2012 14:25:58 -0700 (PDT) Received: by 10.64.22.72 with HTTP; Tue, 25 Sep 2012 14:25:58 -0700 (PDT) In-Reply-To: References: Date: Tue, 25 Sep 2012 14:25:58 -0700 Message-ID: Subject: Re: [DISCUSS] EOL Settings for Platform Specific Files From: Jim Gomes To: dev@activemq.apache.org Content-Type: multipart/alternative; boundary=e89a8f3b9df326a8a204ca8d5ae6 X-Virus-Checked: Checked by ClamAV on apache.org --e89a8f3b9df326a8a204ca8d5ae6 Content-Type: text/plain; charset=ISO-8859-1 +1. I like that solution. On Tue, Sep 25, 2012 at 1:35 PM, Hiram Chirino wrote: > The maven assembly plugin's descriptor should support specifying which EOL > style to use when it adds the file to the distribution archive. That would > be my preference. That way folks can still edit the source files in the > format most natural on the dev platform, but still get the correct EOL > conversion in the final distribution target. > > On Tue, Sep 25, 2012 at 11:58 AM, Jim Gomes wrote: > > > Hello All, > > > > In the ActiveMQ repository, we have a few platform specific script files > > for launching ActiveMQ on (Li|U)nix platforms. Specifically, the > > *activemq* and > > *activemq-admin* script files. Currently, most, but not all, of these > > files have been flagged in Subversion to have the'*eol-style: native* > > meta-attribute. > > This is intended to auto-convert the platform EOL convention, and then > > always store it in the repository as LF-only EOL. However, this creates > a > > problem when building ActiveMQ on a Windows machine which will > subsequently > > be deployed on a (Li|U)nix box. Those script files will have the wrong > EOL > > character, and will not run. > > > > What I am proposing is to change the Subversion meta-attribute to > > *eol-style: > > LF* to always keep these files in their platform-correct format. > Likewise, > > the Windows platform files (*activemq.bat* and *activemq-admin.bat*) > should > > be flagged as *eol-style: CRLF*. > > > > Thoughts and comments? > > > > Best, > > Jim > > > > > > -- > > ** > > *Hiram Chirino* > > *Engineering | Red Hat, Inc.* > > *hchirino@redhat.com | fusesource.com | redhat.com* > > *skype: hiramchirino | twitter: @hiramchirino< > http://twitter.com/hiramchirino> > * > > *blog: Hiram Chirino's Bit Mojo * > --e89a8f3b9df326a8a204ca8d5ae6--