Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@activemq.apache.org
Received-SPF: pass (nike.apache.org: local policy)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
  s=s1024; d=yahoo.com;
  h=X-YMail-OSG:Received:X-Mailer:References:Message-ID:Date:From:Reply-To:Subject:To:In-Reply-To:MIME-Version:Content-Type;
  b=3n8FjbUJQYlrEDqcTkfKZ5ue/SaEiYp/mAR6gHcQAbyCo4UFm6cQ8cAXse29T63TP4YI8VQBwHDgpvU1R1jotzLM9OhLiAoFc6bojrQUS7r8uq5Fa2K0NUMEVctCRAZ/NvS5OcLkBPIasR+vZnUFDYCj0bEdYuXS/RQZPNTZomQ=;
References: 
 <CAGB5yN=x0jJts9DORE8Gk78GrfMqSN1ia=XAvLacFy5+VHCQuA@mail.gmail.com>
 <CAGB5yNmaiPMO=fED0t6Cj0k=rYQ1Q79aZ7B+SgyVuVWakAmw4g@mail.gmail.com>
Message-ID: <1346952546.51573.YahooMailNeo@web39306.mail.mud.yahoo.com>
Date: Thu, 6 Sep 2012 10:29:06 -0700 (PDT)
From: Claudio Corsi <clcorsi@yahoo.com>
Reply-To: Claudio Corsi <clcorsi@yahoo.com>
Subject: Re: [HEADS UP] - Graceful shutdown of AMQ and fixing some leaks when
 doing hot-deployment
To: dev@activemq.apache.org
In-Reply-To: 
 <CAGB5yNmaiPMO=fED0t6Cj0k=rYQ1Q79aZ7B+SgyVuVWakAmw4g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/alternative;
 boundary="-294336953-519296709-1346952546=:51573"

---294336953-519296709-1346952546=:51573
Content-Type: text/plain; charset=us-ascii

Claus,

Why did you not consider using the keep alive option of the thread pool?  This would reclaim threads that have been idle after a given certain time and those resources would of been reclaimed.   The only consideration is that you would need to reduce the number of active threads to a small value since this is useful for created threads that exceed the minimum thread pool size.

--Claudio


>________________________________
> From: Claus Ibsen <claus.ibsen@gmail.com>
>To: dev@activemq.apache.org 
>Sent: Thursday, September 6, 2012 11:20 AM
>Subject: Re: [HEADS UP] - Graceful shutdown of AMQ and fixing some leaks when doing hot-deployment
> 
>Hi
>
>Okay I have been running a bunch of unit tests, and I can see that the
>tests from activemq-core, is kinda dependent on the old behavior
>of shutting down thread pools aggressively using shutdownNow or no
>attempt to wait for in progress tasks to complete gracefully.
>
>So the changes being committed is currently to keep same behavior of
>shutting down. Then we can gently switch over to
>graceful shutdown as we fix the tests and identify the ones to switch over.
>
>So ThreadPoolUtils have 3 set of shutdown methods
>- shutdown
>- shutdownNow
>- shutdownGraceful
>
>The first 2 is just like on the JDK executor service.
>The last one is the graceful one.
>
>
>
>On Thu, Sep 6, 2012 at 2:47 PM, Claus Ibsen <claus.ibsen@gmail.com> wrote:
>> Hi
>>
>> Recently I have been diving into fixing some leaks in ActiveMQ. It
>> started with the activemq-pool component which caused a Camel JMS
>> client to become slower, due memory leaks not being released.
>>
>> The activemq-pool has been fixed now, and runs flawless again.
>> On a side note Tim Bish is working on improving the activemq-pool to
>> be a better pool by leveraging more logic from commons-pool on the
>> connection side as well. Beforehand it was only the sessions that was
>> leveraged.
>>
>> Anyway continuing with the Camel JMS client, we have reports, about
>> leaks in Tomcat, when you redeploy an application. So I have been
>> tracking those down, and got most of it fixed. Have some pending
>> commits for the JMS client.
>>
>> However on embedded a full blow ActiveMQ broker in a web container as
>> Tomcat, and then supporting hot deployment, surfaced some issues with
>> some thread pools not being closed graceful. Instead the pools is
>> closed aggresively, and as some of them have idle threads timeout of
>> 30 seconds, then those threads dont timeout before the application is
>> redeployed (assuming you re-deploy the app; to remedy this you would
>> have to stop the app, and wait for > 30 sec, and then deploy again).
>>
>> As we have some good graceful shutdown code in Camel, I have ported
>> part of that to AMQ, in the ThreadPoolUtils class in the util package.
>> There is a number of shutdown methods, to use for graceful shutdown.
>> When a graceful shutdown of a thread pool is in the works, and if it
>> takes some times, then we now log every 5th second about the shutdown
>> in progress.
>>
>>
>> There is a number of tickets in JIRA about this recent work (all the
>> stuff above, etc.)
>> https://issues.apache.org/jira/browse/AMQ-4026
>> https://issues.apache.org/jira/browse/AMQ-4019
>> https://issues.apache.org/jira/browse/AMQ-3451
>> https://issues.apache.org/jira/browse/AMQ-4016
>> https://issues.apache.org/jira/browse/AMQ-3959
>> https://issues.apache.org/jira/browse/AMQ-3797
>> https://issues.apache.org/jira/browse/AMQ-4008
>> https://issues.apache.org/jira/browse/AMQ-4011
>> https://issues.apache.org/jira/browse/AMQ-3997
>>
>>
>>
>>
>>
>> --
>> Claus Ibsen
>> -----------------
>> FuseSource
>> Email: cibsen@fusesource.com
>> Web: http://fusesource.com
>> Twitter: davsclaus, fusenews
>> Blog: http://davsclaus.com
>> Author of Camel in Action: http://www.manning.com/ibsen
>
>
>
>-- 
>Claus Ibsen
>-----------------
>FuseSource
>Email: cibsen@fusesource.com
>Web: http://fusesource.com
>Twitter: davsclaus, fusenews
>Blog: http://davsclaus.com
>Author of Camel in Action: http://www.manning.com/ibsen
>
>
>
---294336953-519296709-1346952546=:51573--