activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Timothy Bish (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AMQ-4048) When receiving an already expired message, RegionBroker does not update the ExpiredCount statistic
Date Thu, 13 Sep 2012 01:20:08 GMT

    [ https://issues.apache.org/jira/browse/AMQ-4048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13454541#comment-13454541
] 

Timothy Bish commented on AMQ-4048:
-----------------------------------

You need to provide a unit test that shows when this might be happening, from a cursory search
through the code it appears as though all calls to messageExpired do increment the expired
message count, so doing it again there would make the numbers incorrect. 
                
> When receiving an already expired message, RegionBroker does not update the ExpiredCount
statistic
> --------------------------------------------------------------------------------------------------
>
>                 Key: AMQ-4048
>                 URL: https://issues.apache.org/jira/browse/AMQ-4048
>             Project: ActiveMQ
>          Issue Type: Improvement
>          Components: Broker
>    Affects Versions: 5.6.0
>         Environment: All OS, stock Active MQ install
>            Reporter: Marshall Mickelson
>
> When receiving a message which is already expired, RegionBroker sends the message to
the Dead Letter Queue, but does not increment the incoming queue's ExpiredCount statistic.
> The affected file is \activemq-core\src\main\java\org\apache\activemq\broker\region\RegionBroker.java,
method @override messageExpired(...)
> Adding this line resolves the issue:
> node.getRegionDestination().getDestinationStatistics().getExpired().increment();

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message