activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Claus Ibsen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AMQ-4019) Make better use of commons-pool in activemq-pool
Date Wed, 05 Sep 2012 13:21:07 GMT

    [ https://issues.apache.org/jira/browse/AMQ-4019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13448707#comment-13448707
] 

Claus Ibsen commented on AMQ-4019:
----------------------------------

Tim this is great work. I took a peak at the patch. It seems much better than the current
code.

I wonder if when there is an exception from commons-pool, which you rethrown in a JMSException,
if we should enrich the exception with a message about the error. Maybe something "Error borrowing
a connection from the pool", etc. as a caused message to go along.
                
> Make better use of commons-pool in activemq-pool
> ------------------------------------------------
>
>                 Key: AMQ-4019
>                 URL: https://issues.apache.org/jira/browse/AMQ-4019
>             Project: ActiveMQ
>          Issue Type: Improvement
>          Components: activemq-pool
>    Affects Versions: 5.6.0
>            Reporter: Timothy Bish
>            Assignee: Timothy Bish
>            Priority: Minor
>             Fix For: 5.7.0
>
>         Attachments: AMQ4019Patch.txt, AMQ4019Patch.txt
>
>
> Currently activemq-pool uses only a tiny portion of the functionality that's available
in commons-pool opting instead to reinvent a lot of things that now exists there such as keyed
object pools.  We can refactor the current codebase to better use common-pool.  This allows
for easily adding features like enabling async checks for Connections that have idled out
and removing them from the pool as well as adding more diagnostic methods to our API and using
a well tested pooling backend instead of our own custom code.  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message