Return-Path: X-Original-To: apmail-activemq-dev-archive@www.apache.org Delivered-To: apmail-activemq-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7674ED438 for ; Tue, 17 Jul 2012 13:33:39 +0000 (UTC) Received: (qmail 28881 invoked by uid 500); 17 Jul 2012 13:33:39 -0000 Delivered-To: apmail-activemq-dev-archive@activemq.apache.org Received: (qmail 28427 invoked by uid 500); 17 Jul 2012 13:33:38 -0000 Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@activemq.apache.org Delivered-To: mailing list dev@activemq.apache.org Received: (qmail 27113 invoked by uid 99); 17 Jul 2012 13:33:35 -0000 Received: from issues-vm.apache.org (HELO issues-vm) (140.211.11.160) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Jul 2012 13:33:35 +0000 Received: from isssues-vm.apache.org (localhost [127.0.0.1]) by issues-vm (Postfix) with ESMTP id 64E13141BF8 for ; Tue, 17 Jul 2012 13:33:35 +0000 (UTC) Date: Tue, 17 Jul 2012 13:33:35 +0000 (UTC) From: "Gary Tully (JIRA)" To: dev@activemq.apache.org Message-ID: <343911487.63689.1342532015415.JavaMail.jiratomcat@issues-vm> In-Reply-To: <1394440019.61932.1342493554575.JavaMail.jiratomcat@issues-vm> Subject: [jira] [Commented] (AMQ-3933) TransportConnection.dispatchQueue synchronized LinkedList to ConcurrentLinkedQueue MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/AMQ-3933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13416172#comment-13416172 ] Gary Tully commented on AMQ-3933: --------------------------------- can you attach your test or describe the nature of it? > TransportConnection.dispatchQueue synchronized LinkedList to ConcurrentLinkedQueue > ---------------------------------------------------------------------------------- > > Key: AMQ-3933 > URL: https://issues.apache.org/jira/browse/AMQ-3933 > Project: ActiveMQ > Issue Type: Improvement > Affects Versions: 5.6.0 > Environment: Linux > Reporter: Martin Chan Shu Ching > Priority: Minor > Labels: newbie > Original Estimate: 24h > Remaining Estimate: 24h > > TransportConnection.dispatchQueue currently uses a synchronized LinkedList to pass all objects between the broker and the transport connection to the client. This isn't very efficient as the whole list is locked whenever an item is added or removed. ConcurrentLinkedQueue is about 20% faster in my tests. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira