activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gary Tully (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (AMQ-3933) TransportConnection.dispatchQueue synchronized LinkedList to ConcurrentLinkedQueue
Date Thu, 19 Jul 2012 12:44:34 GMT

     [ https://issues.apache.org/jira/browse/AMQ-3933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Gary Tully updated AMQ-3933:
----------------------------

    Attachment: TransportConnectionTest.java

I am not finding any proof of an improvement in my junit tests. In fact, for low number of
threads the concurrent queue is slower.Can you peek at this simple junit test and see if you
can tweek it to demonstrate what you saw.
                
> TransportConnection.dispatchQueue synchronized LinkedList to ConcurrentLinkedQueue
> ----------------------------------------------------------------------------------
>
>                 Key: AMQ-3933
>                 URL: https://issues.apache.org/jira/browse/AMQ-3933
>             Project: ActiveMQ
>          Issue Type: Improvement
>    Affects Versions: 5.6.0
>         Environment: Linux 
>            Reporter: Martin Chan Shu Ching
>            Priority: Minor
>              Labels: newbie
>         Attachments: TestQueue.java, TransportConnectionTest.java
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> TransportConnection.dispatchQueue currently uses a synchronized LinkedList to pass all
objects between the broker and the transport connection to the client. This isn't very efficient
as the whole list is locked whenever an item is added or removed. ConcurrentLinkedQueue is
about 20% faster in my tests.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message