activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Torsten (JIRA)" <jira+amq...@apache.org>
Subject [jira] [Updated] (AMQNET-393) URISupport.ParseQuery is missing decoding of parameters
Date Fri, 13 Jul 2012 15:13:35 GMT

     [ https://issues.apache.org/jira/browse/AMQNET-393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Torsten updated AMQNET-393:
---------------------------

    Attachment: URISupportTest.cs

I wrote a simple Test against the URISupport class that fails at the end because the parameter
is not url decoded.

Not encoding the parameter beforehand would fail and it would not be correct to not encode.
                
> URISupport.ParseQuery is missing decoding of parameters
> -------------------------------------------------------
>
>                 Key: AMQNET-393
>                 URL: https://issues.apache.org/jira/browse/AMQNET-393
>             Project: ActiveMQ .Net
>          Issue Type: Bug
>    Affects Versions: 1.5.1
>            Reporter: Torsten
>            Assignee: Jim Gomes
>         Attachments: URISupportTest.cs
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> The problem is the same as mentioned here: http://timbish.blogspot.de/2011/06/apachenmsactivemq-v151-released.html?showComment=1310415346797#c3045395630917744034
> If the uri contains encoded parameters the will not be correctly decoded in URISupport.ParseQuery.
Hence the match of the certificates subject name fails.
> The fix should be quite simple (not tested):
> Decode the parameter in URISupport.ParseQuery :
> {noformat}
> map[nameValue[0]] = HttpUtility.UrlDecode(nameValue[1]);
> {noformat}
> Example:
> My URL Paramter Value for "tansport.clientcertsubject" ist: 
> CN=system, OU=global, O=ABC, L=Somewhere, S=State, C=com
> In the uri I added it with HttpUtility.UrlDecode() and results in the URL:
> ?serverName=communote-test-broker&transport.clientCertSubject=CN%3dsystem%2c+OU%3dglobal%2c+O%3dABC...
> Now URISupport will parse it, split it by "=" and decode the single parameter values.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message