activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alan Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AMQ-3856) MessageServlet assumes TextMessages contain Text
Date Mon, 28 May 2012 16:14:23 GMT

    [ https://issues.apache.org/jira/browse/AMQ-3856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13284452#comment-13284452
] 

Alan Hudson commented on AMQ-3856:
----------------------------------

Thanks for the fix.  There is one other place that needs it.  writeResponse in MessageServlet.java
needs the same fix.  
                
> MessageServlet assumes TextMessages contain Text
> ------------------------------------------------
>
>                 Key: AMQ-3856
>                 URL: https://issues.apache.org/jira/browse/AMQ-3856
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 5.5.1, 5.6.0
>         Environment: all
>            Reporter: Alan Hudson
>             Fix For: 5.7.0
>
>
> writeMessageResponse assumes that a text message will contain non null text.  It does
a txt.startsWith which crashes with TextMessages with no body.
> It can be fixed with this code:
>     protected void writeMessageResponse(PrintWriter writer, Message message) throws JMSException,
IOException {
>         if (message instanceof TextMessage) {
>             TextMessage textMsg = (TextMessage)message;
>             String txt = textMsg.getText();
>             
>             if (txt != null) {
>                 if (txt.startsWith("<?")) {
>                     txt = txt.substring(txt.indexOf("?>") + 2);
>                 }
>                 writer.print(txt);
>             }
>         } else if (message instanceof ObjectMessage) {
>             ObjectMessage objectMsg = (ObjectMessage)message;
>             Object object = objectMsg.getObject();
>             writer.print(object.toString());
>         }
>     }

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message