Return-Path: X-Original-To: apmail-activemq-dev-archive@www.apache.org Delivered-To: apmail-activemq-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9684598B5 for ; Mon, 12 Dec 2011 19:24:00 +0000 (UTC) Received: (qmail 35741 invoked by uid 500); 12 Dec 2011 19:24:00 -0000 Delivered-To: apmail-activemq-dev-archive@activemq.apache.org Received: (qmail 35712 invoked by uid 500); 12 Dec 2011 19:24:00 -0000 Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@activemq.apache.org Delivered-To: mailing list dev@activemq.apache.org Received: (qmail 35704 invoked by uid 99); 12 Dec 2011 19:24:00 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 12 Dec 2011 19:24:00 +0000 X-ASF-Spam-Status: No, hits=-2001.5 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 12 Dec 2011 19:23:51 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id B4ED610EA06 for ; Mon, 12 Dec 2011 19:23:30 +0000 (UTC) Date: Mon, 12 Dec 2011 19:23:30 +0000 (UTC) From: "Tommy Lindgren (Issue Comment Edited) (JIRA)" To: dev@activemq.apache.org Message-ID: <704749931.2239.1323717810742.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1825569938.5752.1322050539765.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Issue Comment Edited] (AMQ-3605) NullPointerException in TransportConnection MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/AMQ-3605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13167671#comment-13167671 ] Tommy Lindgren edited comment on AMQ-3605 at 12/12/11 7:21 PM: --------------------------------------------------------------- The patch was applied to trunk (checkout from today, r1213236). was (Author: tomyl): The patch was applied to trunk. > NullPointerException in TransportConnection > ------------------------------------------- > > Key: AMQ-3605 > URL: https://issues.apache.org/jira/browse/AMQ-3605 > Project: ActiveMQ > Issue Type: Bug > Components: Transport > Affects Versions: 5.5.0 > Environment: SLES 11 SP1 > java version "1.6.0_23" > perl 5.10.0 + Net::Stomp 0.38_99 > Reporter: Tommy Lindgren > Priority: Critical > Labels: stomp > Attachments: AMQ-3605-Patch.txt, StompDedicatedTaskRunnerTests.java, StompDedicatedTaskRunnerTests.java > > > I'm running ActiveMQ 5.5.0 and clients using Net::Stomp 0.38_99 and I'm seeing infrequent NullPointerExceptions in TransportConnection: > {noformat} > Exception in thread "ActiveMQ Connection Dispatcher: /172.31.201.11:50607" java.lang.NullPointerException > at org.apache.activemq.broker.TransportConnection.service(TransportConnection.java:327) > at org.apache.activemq.broker.TransportConnection$1.onCommand(TransportConnection.java:179) > at org.apache.activemq.transport.TransportFilter.onCommand(TransportFilter.java:69) > at org.apache.activemq.transport.stomp.StompTransportFilter.sendToActiveMQ(StompTransportFilter.java:81) > at org.apache.activemq.transport.stomp.StompSubscription.onMessageDispatch(StompSubscription.java:79) > at org.apache.activemq.transport.stomp.ProtocolConverter.onActiveMQCommand(ProtocolConverter.java:596) > at org.apache.activemq.transport.stomp.StompTransportFilter.oneway(StompTransportFilter.java:58) > at org.apache.activemq.transport.MutexTransport.oneway(MutexTransport.java:40) > at org.apache.activemq.broker.TransportConnection.dispatch(TransportConnection.java:1270) > at org.apache.activemq.broker.TransportConnection.processDispatch(TransportConnection.java:815) > at org.apache.activemq.broker.TransportConnection.iterate(TransportConnection.java:851) > at org.apache.activemq.thread.DedicatedTaskRunner.runTask(DedicatedTaskRunner.java:104) > at org.apache.activemq.thread.DedicatedTaskRunner$1.run(DedicatedTaskRunner.java:42) > {noformat} > This seems to happen 1-2 times per month or so but the result is dire: new messages aren't delivered to the affected client (you can see the number of pending messages increasing in the admin web interface) until the client or ActiveMQ is restarted. > Relevant code snippet from TransportConnection.java, > {noformat} > 326 if (context != null) { > 327 if (context.isDontSendReponse()) { > {noformat} > implies that we are dealing with a race condition. I'm not familiar with the ActiveMQ code base but it looks like it grabs a lock (serviceLock) before entering that function, so not sure what's going on. > Since there's no timestamp associated with the stack trace I'm not completly sure what's going on on the client side. I've tried to reproduce it by writing a small script that uses Net::Stomp in a similar way to my real clients, but no luck so far. > No idea if it's relevant, but my affected clients have been both consuming and producing, and sending/receiving on both topics and queues. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira