activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Timothy Bish (Created) (JIRA)" <>
Subject [jira] [Created] (AMQ-3516) Failover Transport MessageAck commands aren't filtered in oneway
Date Wed, 28 Sep 2011 20:00:48 GMT
Failover Transport MessageAck commands aren't filtered in oneway

                 Key: AMQ-3516
             Project: ActiveMQ
          Issue Type: Bug
          Components: Transport
    Affects Versions: 5.x
            Reporter: Timothy Bish
            Assignee: Timothy Bish
            Priority: Minor

There's some code in FailoverTransport.oneway that was intended to MessageAck commands when
the transport was in a failed state that will never be called.

                if (isShutdownCommand(command) && connectedTransport.get() == null)
                    if (command.isShutdownInfo()) {
                        // Skipping send of ShutdownInfo command when not
                        // connected.
                    if (command instanceof RemoveInfo || command.isMessageAck()) {
                        // Simulate response to RemoveInfo command or ack (as it
                        // will be stale)
                        Response response = new Response();

The inner if statement that looks for MessageAck will never be reachable since a MessageAck
is not a RemoveInfo or ShutdownInfo command which is the condition for getting into the outer

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


View raw message