activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Timothy Bish (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AMQ-3500) Setting destination options should validate against typos
Date Fri, 23 Sep 2011 14:08:26 GMT

    [ https://issues.apache.org/jira/browse/AMQ-3500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13113455#comment-13113455
] 

Timothy Bish commented on AMQ-3500:
-----------------------------------

Looks good.  The patch doesn't apply cleanly though with the test case renamed.

> Setting destination options should validate against typos
> ---------------------------------------------------------
>
>                 Key: AMQ-3500
>                 URL: https://issues.apache.org/jira/browse/AMQ-3500
>             Project: ActiveMQ
>          Issue Type: Improvement
>    Affects Versions: 5.5.0
>            Reporter: Claus Ibsen
>            Assignee: Claus Ibsen
>            Priority: Minor
>             Fix For: 5.6.0
>
>         Attachments: AMQ-3500.patch
>
>
> I think the logic does not validate that all the destination option was succesfully configured.
> http://activemq.apache.org/destination-options.html
> So if you make a typo, AMQ may continue as normal.
> We should add logic like in Camel, where we check the Map is zero after the introspection
logic have set the options.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message