activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Timothy Bish (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (AMQ-3012) HttpTunnelServlet incorrectly swallows exceptions during transport creation.
Date Wed, 06 Jul 2011 23:09:16 GMT

     [ https://issues.apache.org/jira/browse/AMQ-3012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Timothy Bish resolved AMQ-3012.
-------------------------------

       Resolution: Fixed
    Fix Version/s: 5.6.0

Patch applied, thanks!

> HttpTunnelServlet incorrectly swallows exceptions during transport creation.
> ----------------------------------------------------------------------------
>
>                 Key: AMQ-3012
>                 URL: https://issues.apache.org/jira/browse/AMQ-3012
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: Transport
>    Affects Versions: 5.4.1
>            Reporter: Stirling Chow
>            Priority: Minor
>             Fix For: 5.6.0
>
>         Attachments: patch.txt
>
>
> Symptom
> =======
> org.apache.activemq.transport.http.HttpTunnelServlet.java contains the following logic:
>     protected BlockingQueueTransport createTransportChannel(HttpServletRequest request,
HttpServletResponse response) throws IOException {
> ...
>             clients.put(clientID, answer);
>             Transport transport = answer;
>             try {
>                 HashMap options = new HashMap(transportOptions);
>                 transport = transportFactory.serverConfigure(answer, null, options);
>             } catch (Exception e) {
>                IOExceptionSupport.create(e);
>             }
> If the call to transportFactory.serverConfigure(...) throws an exception, IOExceptionSupport.create(e)
is called, which wraps the exception in an IOException, but that IOException is never thrown.
> Solution
> =======
> See attached patch file.  Add a "throw" clause to propagate the IOException.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message