activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Timothy Bish (JIRA)" <j...@apache.org>
Subject [jira] [Closed] (AMQ-2225) PooledConnection obtaind from PooledConnectionFactory overwrites ExceptionListener
Date Sat, 02 Jul 2011 19:16:21 GMT

     [ https://issues.apache.org/jira/browse/AMQ-2225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Timothy Bish closed AMQ-2225.
-----------------------------

       Resolution: Not A Problem
    Fix Version/s:     (was: 5.6.0)

The code is working as it should, the PooledConnectionFactory returns the same PooledConnection
for the same username / password combo so settings exception listeners on one of the two PooledConnection's
created with the same username and password would have to overwrite the other since they are
in fact the same object.

> PooledConnection obtaind from PooledConnectionFactory overwrites ExceptionListener
> ----------------------------------------------------------------------------------
>
>                 Key: AMQ-2225
>                 URL: https://issues.apache.org/jira/browse/AMQ-2225
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 5.2.0
>            Reporter: Lukasz Zielinski
>            Priority: Minor
>
> When multiple connections are obtained from PooledConnectionFactory and ExceptionListeners
are set for them only one ExceptionListener will be notified about connection problems. Issue
is caused by overwriting listeners in shared connection.
> Test case based on http://svn.apache.org/viewvc/activemq/trunk/activemq-pool/src/test/java/org/apache/activemq/pool/PooledTopicPublisherTest.java?view=markup
> public void testSetGetExceptionListener2() throws Exception {
>         PooledConnectionFactory pcf = new PooledConnectionFactory();
>         pcf.setConnectionFactory(new ActiveMQConnectionFactory("vm://test"));
>         TopicConnection conn1 = (TopicConnection) pcf.createConnection();
>         ExceptionListener list1 = new ExceptionListener() {
>             public void onException(JMSException exception) {
>             }
>         };
>         conn1.setExceptionListener(list1);
>         TopicConnection conn2 = (TopicConnection) pcf.createConnection();
>         ExceptionListener list2 = new ExceptionListener() {
>             public void onException(JMSException exception) {
>             }
>         };
>         conn2.setExceptionListener(list2);
>         assertEquals(list1, conn1.getExceptionListener());//this assertion will fail
>         assertEquals(list2, conn2.getExceptionListener());//this assertion will pass
>         assertEquals(list2, conn1.getExceptionListener());// THE PROBLEM - this will
pass
> } 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message