activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gary Tully (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AMQ-1860) soTimeout transport property- Incorrect documentation (or code, you pick)
Date Wed, 01 Jun 2011 13:37:47 GMT

    [ https://issues.apache.org/jira/browse/AMQ-1860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13042167#comment-13042167
] 

Gary Tully commented on AMQ-1860:
---------------------------------

The default for client transports and server side accepted connections (and underlying transports)
is still 0, configureServerSocket is a bit of an anomaly, it applies to just the listen socket,
the socket that does an accept loop such that the accept thread won't block a shutdown.

There is a distinction on the server/broker side between the listen transport and accepted
transports (new connections).

Transport options on the broker side that need to be applied to newly accepted connections
need to use the "transport." prefix. without the prefix, they are applied just to the listener.

> soTimeout transport property- Incorrect documentation (or code, you pick)
> -------------------------------------------------------------------------
>
>                 Key: AMQ-1860
>                 URL: https://issues.apache.org/jira/browse/AMQ-1860
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: Broker, Documentation
>    Affects Versions: 5.0.0, 5.1.0
>         Environment: All
>            Reporter: Filip Hanik
>            Assignee: Rob Davies
>             Fix For: 5.2.0
>
>         Attachments: transport-options.patch
>
>
> The documentation for TCP transport, shows soTimeout, connectionTimeout and socketBufferSize
as properties without a prefix.
> The code in TcpTransportServer.java doesn't have the support for these properties.
> hence setting a URL to tcp://192.168.3.3:61616?soTimeout=180000 does nothing, and defaults
to soTimeout=0 (which is a bad value due to how sockets get closed, and can cause the system
to hang on  a socketWrite call, causing the rest of the server to hang, but I can explain
that on the dev lists for those interested)
> Bug description: Transport properties are incorrectly document or implemented
> There are two solutions to this bug:
> 1. The preferred, would be to fix the documentation
> http://activemq.apache.org/tcp-transport-reference.html
> the mentioned options will work if they are prefixed with "transport."
> so the URL would be 
> tcp://192.168.3.3:61616?transport.soTimeout=180000
> 2. Add the properties with their getters/setters into TcpTransportServer.java and then
during the handleSocket method add them to the options map
> Please note, this bug refers to the soTimeout setting on the socket that gets created
on the server when a producer/consumer connects in using TCP
> best
> Filip

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message