activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "R.I.Pienaar (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AMQ-3135) ActiveMQ.Advisory.Connection messages should contain client ip/host
Date Thu, 19 May 2011 08:39:47 GMT

    [ https://issues.apache.org/jira/browse/AMQ-3135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13036067#comment-13036067
] 

R.I.Pienaar commented on AMQ-3135:
----------------------------------

Testing this and seeing some pretty perplexing results.

Given config:

dev1: no broker connections configured
dev3: 

        <networkConnectors>
                <networkConnector name="dev3-dev1" uri="static:(tcp://dev1.pinetecltd.net:6166)"
userName="amq" password="xxx" duplex="true" decrea    seNetworkConsumerPriority="true" networkTTL="2"
dynamicOnly="true"/>
        </networkConnectors>

When looking at ActiveMQ.Advisory.Connection on dev1 I get:

{"ConnectionInfo": {
  "commandId": 2,
  "responseRequired": false,
  "connectionId": {
    "value": "ID:dev3.xx.net-59818-1305794003658-3:1"
  },
  "clientId": "dev3-dev1_localhost_outbound",
  "clientIp": "dev1.xx.net/88.xx.xx.178:6166",
  "userName": "",
  "password": "",
  "brokerMasterConnector": false,
  "manageable": false,
  "clientMaster": true,
  "faultTolerant": false,
  "failoverReconnect": false
}}


{"ConnectionInfo": {
  "commandId": 5,
  "responseRequired": true,
  "connectionId": {
    "value": "ID:dev1.xx.net-59417-1305793401904-6:2"
  },
  "clientId": "dev3-dev1_localhost_inbound_localhost",
  "clientIp": "vm://localhost#4",
  "userName": "",
  "password": "",
  "brokerMasterConnector": false,
  "manageable": false,
  "clientMaster": true,
  "faultTolerant": false,
  "failoverReconnect": false
}}

Here are the logs:

2011-05-19 09:33:24,231 [xx.xx.181:49049] INFO  TransportConnection            - Started responder
end of duplex bridge dev3-dev1@ID:dev3.xx.net-59818-1305794003658-0:1
2011-05-19 09:33:24,262 [m://localhost#4] INFO  DemandForwardingBridgeSupport  - Network connection
between vm://localhost#4 and tcp:///88.xx.xx.181:49049(localhost) has been established.

#  netstat -an|grep 49049
tcp        0      0 ::ffff:88.xx.xx.178:6166   ::ffff:88.xx.xx.181:49049  ESTABLISHED 


The way I read this is that the first one - dev3-dev1_localhost_outbound - is the connection
from dev3 to dev1 initiating the broker to broker connection and the 2nd one is the back connection
from dev1 to dev3.

The issue is that the first one lists as remote ip the ipaddress of dev1 and not dev3 when
it should be dev3?  In the logs I do see the correct IPs listed and you can see its confirmed
with netstat that the ip/port combination is the connection from the other side so the logs
are right.  Advisories arent.



> ActiveMQ.Advisory.Connection messages should contain client ip/host
> -------------------------------------------------------------------
>
>                 Key: AMQ-3135
>                 URL: https://issues.apache.org/jira/browse/AMQ-3135
>             Project: ActiveMQ
>          Issue Type: Improvement
>          Components: Broker
>    Affects Versions: 5.4.2
>         Environment: CentOS, OpenJDK 6, ActiveMQ 5.4.2
>            Reporter: R.I.Pienaar
>            Assignee: Dejan Bosanac
>            Priority: Minor
>             Fix For: 5.6.0
>
>
> At present a connection advisory message recieved over stomp looks like:
> "ConnectionInfo": {
>   "commandId": 0,
>   "responseRequired": true,
>   "connectionId": {
>     "value": "ID:monitor1.xx.net-57901-1294599217160-5:10017"
>   },
>   "clientId": "ID:monitor1.xx.net-57901-1294599217160-5:10017",
>   "userName": "",
>   "password": "",
>   "brokerMasterConnector": false,
>   "manageable": false,
>   "clientMaster": true,
>   "faultTolerant": false,
>   "failoverReconnect": false
> }}
> Where monitor1.xx.net is the broker name.
> It would be very useful if these messages also included the IP Address, Hostname, Port
of the client connecting.
> There other advisories that would also greatly benefit from this like ActiveMQ.Advisory.NetworkBridge
> thanks

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message