activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Timothy Bish <tabish...@gmail.com>
Subject Re: Apollo does not encode colons in header
Date Wed, 18 May 2011 20:14:28 GMT
On Tue, 2011-05-17 at 10:44 +0200, Lionel Cons wrote:
> Hiram Chirino writes:
>  > Could you get me the full session TCP dump.  I remember doing a recent
>  > change so the the encoding only occurred in 1.1 but not 1.0.
>  > I may have messed something up.
> 
> Here it is, against the latest snapshot (#112):
> 
> 0x0030:  6d01 f371 434f 4e4e 4543 540a 7061 7373  m..qCONNECT.pass
> 0x0040:  636f 6465 3a67 7565 7374 0a68 6f73 743a  code:guest.host:
> 0x0050:  6d69 6764 6576 0a61 6363 6570 742d 7665  broker.accept-ve
> 0x0060:  7273 696f 6e3a 312e 302c 312e 310a 6c6f  rsion:1.0,1.1.lo
> 0x0070:  6769 6e3a 6775 6573 740a 0a00            gin:guest...
> 
> -> client speaks 1.1
> 
> 0x0030:  8e3f f865 434f 4e4e 4543 5445 440a 7665  .?.eCONNECTED.ve
> 0x0040:  7273 696f 6e3a 312e 310a 7365 7276 6572  rsion:1.1.server
> 0x0050:  3a61 7061 6368 652d 6170 6f6c 6c6f 2f31  :apache-apollo/1
> 0x0060:  2e30 2d53 4e41 5053 484f 540a 7365 7373  .0-SNAPSHOT.sess
> 0x0070:  696f 6e3a 6c78 6272 6132 3130 372d 320a  ion:broker107-2.
> 0x0080:  6865 6172 742d 6265 6174 3a31 3030 2c31  heart-beat:100,1
> 0x0090:  3030 3030 0a75 7365 722d 6964 3a67 7565  0000.user-id:gue
> 0x00a0:  7374 0a0a 000a                           st....
> 
> -> server agrees to use 1.1
> 
> 0x0030:  6d01 f372 5345 4e44 0a64 6573 7469 6e61  m..rSEND.destina
> 0x0040:  7469 6f6e 3a2f 7175 6575 652f 7465 7374  tion:/queue/test
> 0x0050:  0a74 7970 653a 7779 7069 7779 630a 7072  .type:wypiwyc.pr
> 0x0060:  6f62 653a 656d 7074 790a 7575 6964 3a61  obe:empty.uuid:a
> 0x0070:  3565 3936 3338 2d34 6464 3233 3437 342d  5e9638-4dd23474-
> 0x0080:  3133 6232 2d31 3334 652d 310a 0a00       13b2-134e-1...
> 
> -> test message sent by client
> 
> 0x0030:  8e3f f478 4d45 5353 4147 450a 7375 6273  .?.xMESSAGE.subs
> 0x0040:  6372 6970 7469 6f6e 3a61 3263 3330 3930  cription:a2c3090
> 0x0050:  2d34 6464 3233 3437 332d 3133 6232 2d65  -4dd23473-13b2-e
> 0x0060:  3964 662d 310a 4a4d 5358 5573 6572 4944  9df-1.JMSXUserID
> 0x0070:  3a67 7565 7374 0a6d 6573 7361 6765 2d69  :guest.message-i
> 0x0080:  643a 6d73 673a 310a 6465 7374 696e 6174  d:msg:1.destinat
> 0x0090:  696f 6e3a 2f71 7565 7565 2f74 6573 740a  ion:/queue/test.
> 0x00a0:  7479 7065 3a77 7970 6977 7963 0a70 726f  type:wypiwyc.pro
> 0x00b0:  6265 3a65 6d70 7479 0a75 7569 643a 6135  be:empty.uuid:a5
> 0x00c0:  6539 3633 382d 3464 6432 3334 3734 2d31  e9638-4dd23474-1
> 0x00d0:  3362 322d 3133 3465 2d31 0a0a 000a       3b2-134e-1....
> 
> -> server sends msg:1 instead of msg\c1
> 
> Cheers,
> 
> Lionel

It looks like the StompProtocolHandler isn't encoding the Message Id
header unlike the other headers it adds, line 744 of
StompProtocolHandler.scala:

      rc ::= (MESSAGE_ID, ascii("msg:"+message_id_counter))

Shouldn't that be:

      rc ::= (MESSAGE_ID, encode_header("msg:"+message_id_counter))

Still figuring out all the code though so I might be missing something
else that's supposed to catch this

Regards


-- 
Tim Bish
------------
FuseSource
Email: tim.bish@fusesource.com
Web: http://fusesource.com
Twitter: tabish121
Blog: http://timbish.blogspot.com/

Connect at CamelOne May 24-26

The Open Source Integration Conference


Mime
View raw message