Return-Path: Delivered-To: apmail-activemq-dev-archive@www.apache.org Received: (qmail 28345 invoked from network); 21 Mar 2011 12:19:43 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 21 Mar 2011 12:19:43 -0000 Received: (qmail 17809 invoked by uid 500); 21 Mar 2011 12:19:43 -0000 Delivered-To: apmail-activemq-dev-archive@activemq.apache.org Received: (qmail 17754 invoked by uid 500); 21 Mar 2011 12:19:42 -0000 Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@activemq.apache.org Delivered-To: mailing list dev@activemq.apache.org Received: (qmail 17746 invoked by uid 99); 21 Mar 2011 12:19:42 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 21 Mar 2011 12:19:42 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 21 Mar 2011 12:19:42 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id D91D3401CFE for ; Mon, 21 Mar 2011 12:19:05 +0000 (UTC) Date: Mon, 21 Mar 2011 12:19:05 +0000 (UTC) From: "Gary Tully (JIRA)" To: dev@activemq.apache.org Message-ID: <1853799791.486.1300709945871.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Created] (AMQ-3231) Stomp Frame should mask passcode header in toString output, so it does not pollute the log MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 Stomp Frame should mask passcode header in toString output, so it does not pollute the log ------------------------------------------------------------------------------------------ Key: AMQ-3231 URL: https://issues.apache.org/jira/browse/AMQ-3231 Project: ActiveMQ Issue Type: Improvement Components: Transport Affects Versions: 5.4.2 Environment: STOMP Reporter: Gary Tully Assignee: Gary Tully Fix For: 5.5.0 Logging of stomp CONNECT frame includes the raw passcode. This should be masked with "****" so instead of:{code}22011-03-18 09:38:30,634 [38.171.43:40701] WARN TransportConnection - Failed to add Connection ID:xx.xx.38456-99-2:3, reason: java.lang.SecurityException: User name or password is invalid. 2011-03-18 09:38:30,634 [38.171.43:40701] WARN ProtocolConverter - Exception occurred processing: CONNECT host:big77 accept-version:1.0,1.1 passcode:bar login:foo{code} it should be:{code}22011-03-18 09:38:30,634 [38.171.43:40701] WARN TransportConnection - Failed to add Connection ID:xx.xx.38456-99-2:3, reason: java.lang.SecurityException: User name or password is invalid. 2011-03-18 09:38:30,634 [38.171.43:40701] WARN ProtocolConverter - Exception occurred processing: CONNECT host:big77 accept-version:1.0,1.1 passcode:***** login:foo{code} -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira