Return-Path: Delivered-To: apmail-activemq-dev-archive@www.apache.org Received: (qmail 138 invoked from network); 14 Feb 2011 14:24:58 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 14 Feb 2011 14:24:58 -0000 Received: (qmail 90563 invoked by uid 500); 14 Feb 2011 14:24:58 -0000 Delivered-To: apmail-activemq-dev-archive@activemq.apache.org Received: (qmail 90316 invoked by uid 500); 14 Feb 2011 14:24:55 -0000 Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@activemq.apache.org Delivered-To: mailing list dev@activemq.apache.org Received: (qmail 90308 invoked by uid 99); 14 Feb 2011 14:24:54 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 14 Feb 2011 14:24:54 +0000 X-ASF-Spam-Status: No, hits=0.7 required=5.0 tests=SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (nike.apache.org: local policy) Received: from [64.251.173.164] (HELO filter3.e-filtering.net) (64.251.173.164) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 14 Feb 2011 14:24:47 +0000 X-ASG-Debug-ID: 1297693461-481900380000-jlJSf7 X-Barracuda-URL: http://64.251.173.164:8000/cgi-bin/mark.cgi Received: from rutabaga.dean (98.159.177.227.dsl.venturecomm.net [98.159.177.227]) by filter3.e-filtering.net (Spam Firewall) with ESMTP id 0A3A84805DA8 for ; Mon, 14 Feb 2011 07:24:21 -0700 (MST) Received: from rutabaga.dean (98.159.177.227.dsl.venturecomm.net [98.159.177.227]) by filter3.e-filtering.net with ESMTP id GzpUhD1m6hreYFAS for ; Mon, 14 Feb 2011 07:24:21 -0700 (MST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Apple Message framework v1081) X-ASG-Orig-Subj: Re: need review on ajax change Subject: Re: need review on ajax change From: Alex Dean In-Reply-To: Date: Mon, 14 Feb 2011 08:24:21 -0600 Content-Transfer-Encoding: quoted-printable Message-Id: References: To: dev@activemq.apache.org X-Mailer: Apple Mail (2.1081) X-Barracuda-Connect: 98.159.177.227.dsl.venturecomm.net[98.159.177.227] X-Barracuda-Start-Time: 1297693462 X-Barracuda-Virus-Scanned: by E-Filtering Spam Firewall at e-filtering.net X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using global scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=5.0 KILL_LEVEL=6.0 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.55315 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Checked: Checked by ClamAV on apache.org Thanks for taking a look! On Feb 14, 2011, at 4:32 AM, Gary Tully wrote: > patch looks good. >=20 > On 13 February 2011 03:17, Alex Dean wrote: >=20 >> I attached a patch to fix = https://issues.apache.org/jira/browse/AMQ-3123. >>=20 >> If a continuation is not available when AjaxListener receives a = message, it >> buffers the message in a linked list for later delivery. >> (MessageListenerServlet checks for any messages buffered in this = way.) The >> problem is that AjaxListener isn't currently maintaining the >> message<->consumer association, so some messages get associated with = the >> wrong callback function when they're sent back to the web browser. >>=20 >> The patch I attached fixes this problem, and I'd appreciate a review = before >> checking it in. >>=20 >> thanks, >> alex >=20 >=20 >=20 >=20 > --=20 > http://blog.garytully.com > http://fusesource.com