activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Allen Reese <are...@yahoo-inc.com>
Subject RE: BrokerFilter using addDestinationInfo
Date Fri, 10 Dec 2010 05:10:22 GMT
On this topic, I noticed that the BrokerFilter interface breaks between 5.3.2 and 5.4.2.

It seems that in 5.3.2 it had:

    public Destination addDestination(ConnectionContext context, ActiveMQDestination destination)
throws Exception {
        return next.addDestination(context, destination);
    }

And in 5.4.2 it has:
    public Destination addDestination(ConnectionContext context, ActiveMQDestination destination,boolean
createIfTemporary) throws Exception {
        return next.addDestination(context, destination,createIfTemporary);
    } 

 Unfortunately, I noticed this too late to complain, so now I maintain 2 branches of my plugin.
 One for 5.3.2, and one for 5.4.2

--Allen

-----Original Message-----
From: Bruce Snyder [mailto:bruce.snyder@gmail.com] 
Sent: Thursday, December 09, 2010 7:38 PM
To: dev@activemq.apache.org
Subject: Re: BrokerFilter using addDestinationInfo

On Thu, Dec 9, 2010 at 5:49 PM, artnaseef <Arthur.Naseef@ticketmaster.com> wrote:
>
> I am currently working on a custom security solution based on the 
> BrokerFilter, which is working well so far, but I've run into this question.
>
> What is the difference between addDestination and addDestinationInfo?
> Should they be treated the same?
>
> Looking through the core ActiveMQ sources, my impression is
> addDestinationInfo() is used in internal broker operations, or 
> broker-to-broker interactions.

You are correct. Although addDestinationInfo() is for internal broker use, you should treat
them the same.

> Any help would be appreciated.
>
> On a more general note - there are more operations on the BrokerFilter 
> for which I'm unclear on their operation.  Is there good documentation 
> somewhere on how and when the operations are called?

Unfortunately the JavaDoc is sorely lacking. If you can't figure something out, just ask here.

Bruce
--
perl -e 'print unpack("u30","D0G)U8V4\@4VYY9&5R\"F)R=6-E+G-N>61E<D\!G;6%I;\"YC;VT*"
);'

ActiveMQ in Action: http://bit.ly/2je6cQ
Blog: http://bruceblog.org/
Twitter: http://twitter.com/brucesnyder

Mime
View raw message