Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@activemq.apache.org
Received-SPF: pass (nike.apache.org: domain of gary.tully@gmail.com designates
 209.85.216.43 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type:content-transfer-encoding;
        b=lBtNhIjt6tJDZNkcnXURFXneUBBMH5P1n2ZuaDFOfd8Y4JM04HSVhOGHANwlGn70tF
         ZKB8C7LoOzT8xBFKodo41NdynSvoL1uHTDoq2HQcbSyGwCeBeSz4zrClZvnh8BPPlPKb
         Mx4GlGx9hbf9pmYhWaE3SmW53n9yfie2NM1s8=
MIME-Version: 1.0
In-Reply-To: <20101108181923.D592823888A6@eris.apache.org>
References: <20101108181923.D592823888A6@eris.apache.org>
Date: Fri, 12 Nov 2010 12:12:36 +0000
Message-ID: <AANLkTi=crdgRY0sSWCMyNy2MMFars_ZexBn13C3XSkVB@mail.gmail.com>
Subject: Re: svn commit: r1032658 -
 /activemq/trunk/activemq-core/src/main/java/org/apache/activemq/TransactionContext.java
From: Gary Tully <gary.tully@gmail.com>
To: dev@activemq.apache.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

Hey Bruce, this change breaks a bunch of tests in the ra module. The
RA does support XA and has some giggery pokery to manage the sessions.
Think this should be reverted.
Hudson has the failures; see the ra module:
https://hudson.apache.org/hudson/job/ActiveMQ/504/#showFailuresLink

On 8 November 2010 18:19,  <bsnyder@apache.org> wrote:
> Author: bsnyder
> Date: Mon Nov =A08 18:19:23 2010
> New Revision: 1032658
>
> URL: http://svn.apache.org/viewvc?rev=3D1032658&view=3Drev
> Log:
> AMQ-3022 - Improve error message when a transaction is attempted to be su=
spended/resumed
>
> Modified:
> =A0 =A0activemq/trunk/activemq-core/src/main/java/org/apache/activemq/Tra=
nsactionContext.java
>
> Modified: activemq/trunk/activemq-core/src/main/java/org/apache/activemq/=
TransactionContext.java
> URL: http://svn.apache.org/viewvc/activemq/trunk/activemq-core/src/main/j=
ava/org/apache/activemq/TransactionContext.java?rev=3D1032658&r1=3D1032657&=
r2=3D1032658&view=3Ddiff
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- activemq/trunk/activemq-core/src/main/java/org/apache/activemq/Transa=
ctionContext.java (original)
> +++ activemq/trunk/activemq-core/src/main/java/org/apache/activemq/Transa=
ctionContext.java Mon Nov =A08 18:19:23 2010
> @@ -334,12 +334,17 @@ public class TransactionContext implemen
> =A0 =A0 =A0 =A0 =A0 =A0 throw new XAException(XAException.XAER_PROTO);
> =A0 =A0 =A0 =A0 }
>
> - =A0 =A0 =A0 =A0// if ((flags & TMJOIN) =3D=3D TMJOIN) {
> - =A0 =A0 =A0 =A0// // TODO: verify that the server has seen the xid
> - =A0 =A0 =A0 =A0// }
> - =A0 =A0 =A0 =A0// if ((flags & TMJOIN) =3D=3D TMRESUME) {
> - =A0 =A0 =A0 =A0// // TODO: verify that the xid was suspended.
> - =A0 =A0 =A0 =A0// }
> + =A0 =A0 =A0 =A0String txSuspendResumeNotSupportMsg =3D "The suspend/res=
ume of a transaction "
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 + "is not supported. Instead it is recommen=
ded that a new JMS session be created.";
> +
> + =A0 =A0 =A0 =A0if ((flags & TMJOIN) =3D=3D TMJOIN) {
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 throw new XAException(txSuspendResumeNotSup=
portMsg);
> + =A0 =A0 =A0 =A0// TODO: verify that the server has seen the xid
> + =A0 =A0 =A0 =A0}
> + =A0 =A0 =A0 =A0if ((flags & TMRESUME) =3D=3D TMRESUME) {
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 throw new XAException(txSuspendResumeNotSup=
portMsg);
> + =A0 =A0 =A0 =A0// TODO: verify that the xid was suspended.
> + =A0 =A0 =A0 =A0}
>
> =A0 =A0 =A0 =A0 // associate
> =A0 =A0 =A0 =A0 synchronizations =3D null;
>
>
>


--=20
http://blog.garytully.com
http://fusesource.com