Return-Path: Delivered-To: apmail-activemq-dev-archive@www.apache.org Received: (qmail 54025 invoked from network); 25 Oct 2010 22:00:05 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 25 Oct 2010 22:00:05 -0000 Received: (qmail 53393 invoked by uid 500); 25 Oct 2010 22:00:05 -0000 Delivered-To: apmail-activemq-dev-archive@activemq.apache.org Received: (qmail 53361 invoked by uid 500); 25 Oct 2010 22:00:05 -0000 Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@activemq.apache.org Delivered-To: mailing list dev@activemq.apache.org Received: (qmail 53353 invoked by uid 99); 25 Oct 2010 22:00:05 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 25 Oct 2010 22:00:05 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 25 Oct 2010 22:00:02 +0000 Received: from thor (localhost [127.0.0.1]) by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id o9PLxfQX028274 for ; Mon, 25 Oct 2010 21:59:41 GMT Message-ID: <26793865.67691288043981526.JavaMail.jira@thor> Date: Mon, 25 Oct 2010 17:59:41 -0400 (EDT) From: "Timothy Bish (JIRA)" To: dev@activemq.apache.org Subject: [jira] Resolved: (AMQ-2988) Allow to retrieve the JMSProperties when using JMS Stream (ActiveMQInputStream) In-Reply-To: <32165359.59941287477161104.JavaMail.jira@thor> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: ae95407df07c98740808b2ef9da0087c X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/activemq/browse/AMQ-2988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Bish resolved AMQ-2988. ------------------------------- Resolution: Fixed Fix Version/s: 5.5.0 Patch applied with modifications to make the properties map unmodifiable and use the generic Collections.emptyMap method instead of creating a new empty map. Thanks. > Allow to retrieve the JMSProperties when using JMS Stream (ActiveMQInputStream) > ------------------------------------------------------------------------------- > > Key: AMQ-2988 > URL: https://issues.apache.org/activemq/browse/AMQ-2988 > Project: ActiveMQ > Issue Type: Improvement > Components: Broker > Reporter: Norman Maurer > Assignee: Timothy Bish > Fix For: 5.5.0 > > Attachments: ActiveMQInputStream_JMSProps.diff, AMQ-2988_junit.diff > > > When using JMS Streams (aka ActiveMQInputStream and ActiveMQOutputStream) its impossible to retrieve the used JMS Properties which where used while writing the OutputStream. The only method which allows this is the ActiveMQInputStream.receive() method. But this will corrupt the InputStream because it will remove the Message from it. > So I think it makes sense to add a method for retrieving the Properties. I also think the receive() method should be private or protected to guard against wrong usage ( I used it before to retrieve the properties and wondered why it corrupted the stream). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.