activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Nawrocki (JIRA)" <j...@apache.org>
Subject [jira] Reopened: (AMQ-2813) BrokerService @PostConstruct invalidates XBeanBrokerService w/ start=false
Date Wed, 01 Sep 2010 17:22:41 GMT

     [ https://issues.apache.org/activemq/browse/AMQ-2813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Dan Nawrocki reopened AMQ-2813:
-------------------------------


Still doesn't work as of AMQ 5.4.0.

Let me explain what I'm trying to do:
1) Shared file system master-slave using nfsv4
2) Broker instantiated by Spring

The 1st AS will come up OK, but the 2nd (3rd, 4th, etc) AS will block indefinitely at org.apache.activemq.store.kahadb.MessageDatabase.lock(MessageDatabase.java:329).
 Spring is calling the @PostConstruct method on BrokerService, which doesn't (cannot) check
the XBeanBrokerService's 'start' flag.

Removal of the @PostConstruct annotation on BrokerService#start fixed the issue for 5.3.2,
I haven't verified on 5.4.0.

> BrokerService @PostConstruct invalidates XBeanBrokerService w/ start=false
> --------------------------------------------------------------------------
>
>                 Key: AMQ-2813
>                 URL: https://issues.apache.org/activemq/browse/AMQ-2813
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 5.3.1
>            Reporter: Dan Nawrocki
>            Assignee: Dejan Bosanac
>            Priority: Minor
>             Fix For: 5.4.0
>
>
> - XBeanBrokerService#afterPropertiesSet() method checks the start flag and is annotated
as @PostConstruct so it's called at startup
> - BrokerService#start() method has the @PostConstruct annotation as well
> - There is no way for the BrokerService class to check the 'start' flag in the XBeanBrokerService
subclass.
> - Spring will call BOTH @PostConstruct methods resulting in the broker being started
regardless of the xbean start flag
> According to Gary Tully:
> That looks like a bug that was introduced in
> http://svn.apache.org/viewvc?rev=908182&view=rev the postConstruct on
> the start method does invalidate the
> XBeanBrokerService#afterPropertiesSet()  smarts. 
> As discussed in:
> http://old.nabble.com/XBean-%27start%3Dfalse%27-not-working--td29086727.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message