Return-Path: Delivered-To: apmail-activemq-dev-archive@www.apache.org Received: (qmail 39851 invoked from network); 8 Jul 2010 14:41:18 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 8 Jul 2010 14:41:18 -0000 Received: (qmail 35294 invoked by uid 500); 8 Jul 2010 14:41:18 -0000 Delivered-To: apmail-activemq-dev-archive@activemq.apache.org Received: (qmail 35148 invoked by uid 500); 8 Jul 2010 14:41:17 -0000 Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@activemq.apache.org Delivered-To: mailing list dev@activemq.apache.org Received: (qmail 35140 invoked by uid 99); 8 Jul 2010 14:41:17 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 08 Jul 2010 14:41:17 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 08 Jul 2010 14:41:14 +0000 Received: from thor (localhost [127.0.0.1]) by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id o68EeqHi019338 for ; Thu, 8 Jul 2010 14:40:53 GMT Message-ID: <19464410.35871278600052638.JavaMail.jira@thor> Date: Thu, 8 Jul 2010 10:40:52 -0400 (EDT) From: "Gary Tully (JIRA)" To: dev@activemq.apache.org Subject: [jira] Resolved: (AMQ-2542) Tidy up store duplicate suppression from failover recovery - consistent store implementation with help from transportConnection In-Reply-To: <248926289.1261394875492.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: ae95407df07c98740808b2ef9da0087c X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/activemq/browse/AMQ-2542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Tully resolved AMQ-2542. ----------------------------- Resolution: Fixed resolved in 961783 Implemented for KahaDB and JDBC. > Tidy up store duplicate suppression from failover recovery - consistent store implementation with help from transportConnection > ------------------------------------------------------------------------------------------------------------------------------- > > Key: AMQ-2542 > URL: https://issues.apache.org/activemq/browse/AMQ-2542 > Project: ActiveMQ > Issue Type: Improvement > Components: Broker > Affects Versions: 5.3.0 > Reporter: Gary Tully > Assignee: Gary Tully > Fix For: 5.4.0 > > > With failover - with a failure before a reply is received to a send or a transaction commit, the send or transaction will be replayed and will be a duplicate. > The transportConnector should know that recovery/reconnection has happened and should enforce duplicate suppression based on obtaining the last producer sequence number from the store. > Currently, duplicate suppression happens at the jdbc message store add, amq store reference store etc... it is not consistent and it is abased on a suitable audit window which may be non deterministic. Would be best to be fully deterministic and consistent (as in a single persistence adapter api) > To make this perform, a transportConnection needs to be flagged as a reconnect which can precipitate the duplicate suppression, possibly needing a wireformat update. This flag would also help with unmatched acks after failover but maybe that flag can be in an ack... > This is relevant both when the broker is restarted or when a connection is dropped. > related issue with relevant test : https://issues.apache.org/activemq/browse/AMQ-2540 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.