activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alan Yu (JIRA)" <j...@apache.org>
Subject [jira] Commented: (AMQ-1477) Simplify the DiscoveryAgent interface
Date Thu, 03 Jun 2010 21:11:54 GMT

    [ https://issues.apache.org/activemq/browse/AMQ-1477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=59933#action_59933
] 

Alan Yu commented on AMQ-1477:
------------------------------

With this change, my MulticastDiscoveryAgent will only get "localhost" as the broker name
no matter what value I set in broker's activemq.xml
Is this a bug? My application is broken when upgrading from 4.1.1 to 5.x

@@ -398,7 +353,7 @@
         if (selfService != null) {
             String payload = getType();
             payload += started.get() ? ALIVE : DEAD;
-            payload += DELIMITER + brokerName + DELIMITER;
+            payload += DELIMITER + "localhost" + DELIMITER;
             payload += selfService;
             try {
                 byte[] data = payload.getBytes();


> Simplify the DiscoveryAgent interface
> -------------------------------------
>
>                 Key: AMQ-1477
>                 URL: https://issues.apache.org/activemq/browse/AMQ-1477
>             Project: ActiveMQ
>          Issue Type: Improvement
>          Components: Broker
>    Affects Versions: 4.0
>            Reporter: Hiram Chirino
>            Assignee: Hiram Chirino
>             Fix For: 5.0.0
>
>
> The DiscoveryAgent interface is a little leaky.  It defines setters and getters for the
brokerName and group fields but that kind of info is not always needed by a discovery agent.
 Those methods should get removed for the interface.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message