Return-Path: Delivered-To: apmail-activemq-dev-archive@www.apache.org Received: (qmail 17061 invoked from network); 19 May 2010 09:28:48 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 19 May 2010 09:28:48 -0000 Received: (qmail 33010 invoked by uid 500); 19 May 2010 09:28:48 -0000 Delivered-To: apmail-activemq-dev-archive@activemq.apache.org Received: (qmail 32834 invoked by uid 500); 19 May 2010 09:28:47 -0000 Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@activemq.apache.org Delivered-To: mailing list dev@activemq.apache.org Received: (qmail 32825 invoked by uid 99); 19 May 2010 09:28:46 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 19 May 2010 09:28:46 +0000 X-ASF-Spam-Status: No, hits=-1443.3 required=10.0 tests=ALL_TRUSTED,AWL X-Spam-Check-By: apache.org Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 19 May 2010 09:28:45 +0000 Received: from thor (localhost [127.0.0.1]) by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id o4J9SPv9002313 for ; Wed, 19 May 2010 09:28:25 GMT Message-ID: <29455463.931274261305245.JavaMail.jira@thor> Date: Wed, 19 May 2010 05:28:25 -0400 (EDT) From: "Martin Carpella (JIRA)" To: dev@activemq.apache.org Subject: [jira] Commented: (AMQ-2556) Memory leaks with XA Transactions (case of read-only transactions) In-Reply-To: <917186682.821262613735393.JavaMail.jira@brutus.apache.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: ae95407df07c98740808b2ef9da0087c [ https://issues.apache.org/activemq/browse/AMQ-2556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=59443#action_59443 ] Martin Carpella commented on AMQ-2556: -------------------------------------- Is the fix-version 5.4.0 correct, i.e. fix is not included in 5.3.2? > Memory leaks with XA Transactions (case of read-only transactions) > ------------------------------------------------------------------ > > Key: AMQ-2556 > URL: https://issues.apache.org/activemq/browse/AMQ-2556 > Project: ActiveMQ > Issue Type: Bug > Components: Broker, JMS client > Affects Versions: 5.1.0, 5.2.0, 5.3.0 > Environment: ActiveMQ 5.3.0 > Atomikos Transactions Essentials 3.5.8 > Spring 2.5.6 > Oracle 11g (thin driver version 11.1.0.7.0) > Reporter: Daniel Santos > Assignee: Gary Tully > Fix For: 5.4.0 > > Attachments: XAConsumer.zip > > > Some transaction related information are not released in case of read-only transactions (where not messages have been consumed or produced) by broker and client, that causes an OutOfMemory after running some time. > Fields that hold these "transaction related information" are (at least) : > - {{org.apache.activemq.state.ConnectionState.transactions}} > - {{org.apache.activemq.TransactionContext.ENDED_XA_TRANSACTION_CONTEXTS}} > After serach, it seems that the case of read-only XA transactions (that terminates at prepare time) has been missed in some code like : > - {{org.apache.activemq.broker.TransportConnection}} that puts TransactionState in {{org.apache.activemq.state.ConnectionState.transactions}} at the beginning, release them at commit (or rollback) time *but not at prepare time where result is {{XAResource.XA_RDONLY}}* > - {{org.apache.activemq.TransactionContext}} that do the same mistake via ENDED_XA_TRANSACTION_CONTEXTS in prepare() > _Note that the case of read-only transactions seems correctly done by {{org.apache.activemq.transaction.XATransaction}} (very interesting comment here http://fisheye6.atlassian.com/browse/activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transaction/XATransaction.java?r=809940#l175)_ -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.