Return-Path: Delivered-To: apmail-activemq-dev-archive@www.apache.org Received: (qmail 56570 invoked from network); 9 Apr 2010 19:48:54 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 9 Apr 2010 19:48:54 -0000 Received: (qmail 1418 invoked by uid 500); 9 Apr 2010 19:48:54 -0000 Delivered-To: apmail-activemq-dev-archive@activemq.apache.org Received: (qmail 1393 invoked by uid 500); 9 Apr 2010 19:48:54 -0000 Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@activemq.apache.org Delivered-To: mailing list dev@activemq.apache.org Received: (qmail 1384 invoked by uid 99); 9 Apr 2010 19:48:54 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 09 Apr 2010 19:48:54 +0000 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests=FREEMAIL_FROM,SPF_HELO_PASS,SPF_PASS,T_TO_NO_BRKTS_FREEMAIL X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of lists@nabble.com designates 216.139.236.158 as permitted sender) Received: from [216.139.236.158] (HELO kuber.nabble.com) (216.139.236.158) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 09 Apr 2010 19:48:47 +0000 Received: from isper.nabble.com ([192.168.236.156]) by kuber.nabble.com with esmtp (Exim 4.63) (envelope-from ) id 1O0KBl-000891-S4 for dev@activemq.apache.org; Fri, 09 Apr 2010 12:48:25 -0700 Message-ID: <28196721.post@talk.nabble.com> Date: Fri, 9 Apr 2010 12:48:25 -0700 (PDT) From: pmmerritt1 To: dev@activemq.apache.org Subject: Re: ActiveMQ JMSPriority (AMQ-122) In-Reply-To: <28170545.post@talk.nabble.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Nabble-From: pmmerritt@gmail.com References: <28170545.post@talk.nabble.com> X-Virus-Checked: Checked by ClamAV on apache.org I added the files as suggested using svn add and created a new patch file and will upload it, however I cannot get to the issues.apache.org site right now for some reason. As far as unit testing goes I did write a unit test specifically to test priority "JmsPriorityTest". It sends 200 messages using a modulus to send priorities 1,2,3,4,5,6,7,8,9,10 in repeating order and then verifies that it receives them in the correct priority order (10,10,10,10,9,9,9,9....1,1,1,1). In addition, I temporarily updated the MessageDispatchChannelFactory to always return the PrioritizedDispatchMessageChannel and ran some of the unit tests and got the same results as before although I did not run all of them because the tests using SSL will not run on my machine for some reason. Can you think of some good tests already included in activemq-core that would be good to run with a prioritized broker as well? Theoretically all of them should still run with the PrioritizedDispatchMessageChannel as long as none of the tests are specifying the JMSPriority, but rerunning all of them would be overkill. If you can think of some specific ones that would be good to run again with a Prioritized broker I will look into converting them to run both with and without the useJmsPriority flag. Thanks, Phil -- View this message in context: http://old.nabble.com/ActiveMQ-JMSPriority-%28AMQ-122%29-tp28170545p28196721.html Sent from the ActiveMQ - Dev mailing list archive at Nabble.com.