activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bruce Snyder <bruce.sny...@gmail.com>
Subject Re: ActiveMQ JMSPriority (AMQ-122)
Date Fri, 09 Apr 2010 18:08:30 GMT
On Fri, Apr 9, 2010 at 11:43 AM, pmmerritt1 <pmmerritt@gmail.com> wrote:
>
> I have attached the files to AMQ-122. I cleaned up the implementation a
> little bit before attaching
>
> In summary I made the following changes
> 1) Added a useJmsPriority option to the Broker
> 2) Added the useJmsPriority parameter to the BrokerInfo class
> 3) Updated code which was creating BrokerInfo instances to set the
> useJmsPriority
> 4) Converted MessageDispatchChannel into an Interface
> 5) Created a new class FifoMessageDispatchChannel which implements
> MessageDispatchChannel and contains the same implementation as was
> previously in MessageDispatchChannel
> 6) Created a new class PriorityMessageDispatchChannel which contains the
> newly created PrioritizedMessageDispatchChannel. This implementation
> contains an array of priority linkedlists and a current index to the highest
> priority linkedlist. So messages are dequeued from the highest priority
> linked list with messages and enqueued to the linked list which corresponds
> to the priority in the message.
> 7) Created a MessageDispatchChannelFactory which returns the appropriate
> MessageDispatchChannel dependent upon the value of the useJmsPriority
> parameter
> 8) Updated ActiveMQConnection and ActiveMQSession to only override the
> message priority when useJmsPriority is false or the message priority is not
> set.
> 9) Added a new unit test JmsPriorityTest in order to test priority ordering

If you 'svn add' the new files so that they're scheduled to be added
to the repo, then they will be included in the diff file. Do you have
JUnit test that validates these changes at all? Providing tests will
expedite the process.

Bruce
-- 
perl -e 'print unpack("u30","D0G)U8V4\@4VYY9&5R\"F)R=6-E+G-N>61E<D\!G;6%I;\"YC;VT*"
);'

ActiveMQ in Action: http://bit.ly/2je6cQ
Blog: http://bruceblog.org/
Twitter: http://twitter.com/brucesnyder

Mime
View raw message