activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Timothy Bish (JIRA)" <jira+amq...@apache.org>
Subject [jira] Commented: (AMQNET-245) Stomp.MessageProducer doesn't set the TimeStamp to zero (unix epoc) if DisableMessageTimestamp is true.
Date Wed, 17 Mar 2010 13:57:45 GMT

    [ https://issues.apache.org/activemq/browse/AMQNET-245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=58287#action_58287
] 

Timothy Bish commented on AMQNET-245:
-------------------------------------

Just double checked and the broker will set the "timestamp" field so adding that should be
fine.  You'd need to add in the read of the TimeStamp header in the StompWireFormat as well
I'd think.

Can you work up a complete patch with the changes needed and include a Unit Test to validate
that the functionality is working as expected.  That would help us out a lot since I won't
have time to get to that this week.

> Stomp.MessageProducer doesn't set the TimeStamp to zero (unix epoc) if DisableMessageTimestamp
is true.
> -------------------------------------------------------------------------------------------------------
>
>                 Key: AMQNET-245
>                 URL: https://issues.apache.org/activemq/browse/AMQNET-245
>             Project: ActiveMQ .Net
>          Issue Type: Improvement
>          Components: Stomp
>         Environment: Win7, VS2008, .netcf-2.0
>            Reporter: Andreas Ländle
>            Assignee: Timothy Bish
>            Priority: Trivial
>         Attachments: MessageProducer.patch
>
>
> If I interpret the comment on Apache.NMS.IMessage.NMSTimestamp correctly, the timestamp
of a message of send by a message producer with disabled timstamping should reflect the unix
epoc. This is also what the JMS specification says in section 3.4.4 (JMSTimestamp).
> But since the TimeStamp property of a message is set to DateTime.UtcNow in Apache.NMS.Stomp.Commands.Message.ctor()
and the Apache.NMS.Stomp.MessageProducer.Send(...) implementation only updates the message
timestamp (if message timestampng isn't disabled for the producer), the timestamp of a message
send via STOMP can never be "zero" (=unix epoc).
> Maybe a simple solution might be to add an else-branch to the MessageProducer-Send-implementation
(see attached patch file), but i don't know if this follows the NMS-projects design intentions.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message