activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vesna Djurdjevic (JIRA)" <>
Subject [jira] Commented: (AMQ-1529) The blob of a blob-message will never be deleted
Date Wed, 10 Mar 2010 14:17:49 GMT


Vesna Djurdjevic commented on AMQ-1529:

I have checked the error 500 in the activemq-fileserver. 
The problem is that streams are not closed when the file is uploaded on the server.

this would fix the problem
    protected void doPut(HttpServletRequest request, HttpServletResponse response) throws
ServletException, IOException {

        // some code missing here...

        FileOutputStream out = new FileOutputStream(file);
        try {
            IO.copy(request.getInputStream(), out);
        } catch (IOException e) {
            Log.warn(Log.EXCEPTION, e); // is this obsolete?
            throw e;

        response.setStatus(HttpURLConnection.HTTP_NO_CONTENT); // we return no
                                                                // content

Also in should be added removing the blob files when the message is

> The blob of a blob-message will never be deleted
> ------------------------------------------------
>                 Key: AMQ-1529
>                 URL:
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: Message Store
>    Affects Versions: 5.0.0, 5.1.0, 5.2.0
>         Environment: Windows vista, java 6
>            Reporter: Marco Buss
>            Assignee: Rob Davies
>             Fix For: 5.4.0
>         Attachments: patch.txt
> In a blob-message you can specify that the broker can delete the blob if the message
is delivered or outdated.
> But actual onle the message with the reference to the blob is deletet, the use-data in
the repository not. The problem is the separation of the blob from the message itself.
> My idea is to extend the persistence store to check at delete if it is a blob message
and then delete the blob from the repository. I have done this in the jdbc- and kaha message
store (see patch).
> JDBC message store:
> - created a new table with all blob url`s which must be delete if the message is deleted
> | ID (primary Key) | MSGID (reference to ID in MESSAGE table) | URL |
> - on message add check if it is a blob-message and if the broker must delete the message
add the information to the new table
> - in cleanup a query on that table finds all urls with no existing reference in the MESSAGE
table (becaus the message is deleted) and then deletes this blobs
> KAHA message store:
> - TopicSubAck has a new attribute remotBlobUrl
> - on message add check if it is a blob-message and if the broker must delete the message
add the url to the TopicSubAck
> - on acknowledge at delete check if the attribute is set an if it is set delete the blob
> - add a similar mechanism to the other message stores
> - only the first delete is successfull, every other delete request ends in an 500 errorcode
from the server

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message