activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Gomes (JIRA)" <jira+amq...@apache.org>
Subject [jira] Resolved: (AMQNET-233) Code cleanup: clean unused "using statements, unused dll references and correct the inconsistent end of line delimiters
Date Tue, 09 Feb 2010 18:35:35 GMT

     [ https://issues.apache.org/activemq/browse/AMQNET-233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Jim Gomes resolved AMQNET-233.
------------------------------

       Resolution: Fixed
    Fix Version/s:     (was: 1.2.1)
                   1.3.0

Applied patch from Sebastien.  Thanks!
I reverted a couple of the changes, because they broke other platform builds.  The using directives
for the .NET 3.5 platform were incorrectly removed, and the using directives for the .NET
Compact Framework platform were broken in one file.

> Code cleanup: clean unused "using statements, unused dll references and correct the inconsistent
end of line delimiters
> -----------------------------------------------------------------------------------------------------------------------
>
>                 Key: AMQNET-233
>                 URL: https://issues.apache.org/activemq/browse/AMQNET-233
>             Project: ActiveMQ .Net
>          Issue Type: Improvement
>          Components: NMS
>    Affects Versions: 1.2.0
>            Reporter: Sebastien Rodriguez
>            Assignee: Jim Gomes
>            Priority: Trivial
>             Fix For: 1.3.0
>
>         Attachments: NMS.UsingStatements&RefClean.patch
>
>   Original Estimate: 1 hour
>  Remaining Estimate: 1 hour
>
> There are a lot of unused using statements across the Apache.NMS solution. 
> As they just add some unnecessary noise to the codebase, we should remove them. We can
also take the opportunity of such effort and organize them.
> Also, I found some unnecessary referenced dlls (System.Data in the vs2008-nms project,
System.Data in the vs2008-nms-test project)
> I also encountered some inconsistent end of lines in two files, I took the opportunity
of this small cleanup to make them consistent with the other files (CR LF)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message