Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@activemq.apache.org
Message-ID: <245632943.6241264790672630.JavaMail.jira@brutus.apache.org>
Date: Fri, 29 Jan 2010 18:44:32 +0000 (UTC)
From: "Gary Tully (JIRA)" <jira@apache.org>
To: dev@activemq.apache.org
Subject: [jira] Resolved: (AMQ-2585) ActiveMQTextMessage.getSize() does not
 consider size of properties
In-Reply-To: <1402312490.4481264687292758.JavaMail.jira@brutus.apache.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/activemq/browse/AMQ-2585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gary Tully resolved AMQ-2585.
-----------------------------

       Resolution: Fixed
    Fix Version/s: 5.4.0
         Assignee: Gary Tully

thanks for the test case. I made some mods as the override of min message size is only relevant to the broker. The size is calculated on demand for consumers.
committed in r904585

> ActiveMQTextMessage.getSize() does not consider size of properties
> ------------------------------------------------------------------
>
>                 Key: AMQ-2585
>                 URL: https://issues.apache.org/activemq/browse/AMQ-2585
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: JMS client
>    Affects Versions: 5.3.0
>            Reporter: Magnus Persson
>            Assignee: Gary Tully
>            Priority: Minor
>             Fix For: 5.4.0
>
>         Attachments: ReasonableTextMessageSize.patch
>
>
> Checking the size of a text message only considers the body of a message, not the properties. I think this relates to a typo in the method:
> {noformat}
>     public int getSize() {
>         if (size == 0 && content == null && text != null) {
>             size = getMinimumMessageSize();
>             if (marshalledProperties != null) {
>                 size += marshalledProperties.getLength();
>             }
>             size = text.length() * 2;
>         }
>         return super.getSize();
>     }
> {noformat}
> This should perhaps be size += text.length() * 2?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.