activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dave Stanley (JIRA)" <>
Subject [jira] Created: (AMQ-2507) When using a producer/session with a send timeout, send() doesn't throw an exception if the timeout is reached.
Date Mon, 23 Nov 2009 20:07:52 GMT
When using a producer/session with a send timeout, send() doesn't throw an exception if the
timeout is reached.

                 Key: AMQ-2507
             Project: ActiveMQ
          Issue Type: Improvement
          Components: Broker
    Affects Versions: 5.3.0
         Environment: All platforms, 5.3.x
            Reporter: Dave Stanley

In the attached testcase we set a low broker memory limit (to force a producer to block due
to the memory usage limit being hit), and also set a sendtimeout on the connection to force
the producer.send() to return if it cannot send a message within the timeout period.

On running the test the broker sends messages until the timeout kicks in. Once the hits the
memory limit it blocks and the producer.send() returns after the timeout.

The problem is there is no way to know that the send() failed. This improvement is to modify
the session to throw an exception of some kind when the sendTimeout is reached.

I have attached the testcase without a fix as its not clear the best approach to fix.

One possible solution is to modify ActiveMQSession, but need some clarification on whats the
best JMSException to throw.  It doesn't look like this is explicitly spelled out in the JMS

General area is the send() method

protected void send(ActiveMQMessageProducer producer, ActiveMQDestination destination, Message
message, int deliveryMode, int priority, long timeToLive,
                        MemoryUsage producerWindow, int sendTimeout) throws JMSException {

           if (sendTimeout <= 0 && !msg.isResponseRequired() && !connection.isAlwaysSyncSend()
&& (!msg.isPersistent() || connection.isUseAsyncSend() || txid != null)) {
                if (producerWindow != null) {
                    // Since we defer lots of the marshaling till we hit the
                    // wire, this might not
                    // provide and accurate size. We may change over to doing
                    // more aggressive marshaling,
                    // to get more accurate sizes.. this is more important once
                    // users start using producer window
                    // flow control.
                    int size = msg.getSize();
            } else {
                // Handle send timeout here
                if (sendTimeout > 0) {
                	Object response = this.connection.syncSendPacket(msg,sendTimeout);
                    if(response == null) {
                    	LOG.debug(getSessionId() + " timeout sending message: " + msg);

                    // What jms exception is most appropriate to throw here?
                }else {

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message