From dev-return-17149-apmail-activemq-dev-archive=activemq.apache.org@activemq.apache.org Tue Oct 06 15:41:17 2009 Return-Path: Delivered-To: apmail-activemq-dev-archive@www.apache.org Received: (qmail 37284 invoked from network); 6 Oct 2009 15:41:17 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 6 Oct 2009 15:41:17 -0000 Received: (qmail 8436 invoked by uid 500); 6 Oct 2009 15:41:17 -0000 Delivered-To: apmail-activemq-dev-archive@activemq.apache.org Received: (qmail 8409 invoked by uid 500); 6 Oct 2009 15:41:17 -0000 Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@activemq.apache.org Delivered-To: mailing list dev@activemq.apache.org Received: (qmail 8396 invoked by uid 99); 6 Oct 2009 15:41:17 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Oct 2009 15:41:17 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Oct 2009 15:41:14 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id CA3E4234C051 for ; Tue, 6 Oct 2009 08:40:52 -0700 (PDT) Message-ID: <233374974.1254843652826.JavaMail.jira@brutus> Date: Tue, 6 Oct 2009 08:40:52 -0700 (PDT) From: "Dejan Bosanac (JIRA)" To: dev@activemq.apache.org Subject: [jira] Resolved: (AMQ-2441) TimeStampingBrokerPlugin Not Working on Fuse 5.3.0.4 In-Reply-To: <342603832.1254757013563.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: ae95407df07c98740808b2ef9da0087c X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/activemq/browse/AMQ-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dejan Bosanac resolved AMQ-2441. -------------------------------- Resolution: Fixed Fix Version/s: 5.3.0 Assignee: Dejan Bosanac I applied modified patch. I set that ignoring setting values in the past is optional and off by default. It makes sense in some use cases, for example when all clients are on the same machine. But what if only some producers have wrong clocks and consumers are in the sync with the broker? The purpose of this plugin is to use broker time as relevant, but with this patch it will be also possible to prevent these changes. All you have to do is to set futureOnly property to true. Thanks > TimeStampingBrokerPlugin Not Working on Fuse 5.3.0.4 > ---------------------------------------------------- > > Key: AMQ-2441 > URL: https://issues.apache.org/activemq/browse/AMQ-2441 > Project: ActiveMQ > Issue Type: Bug > Components: Broker > Affects Versions: 5.3.0 > Reporter: Aryeh Sivan > Assignee: Dejan Bosanac > Priority: Minor > Fix For: 5.3.0 > > Attachments: TimeStampingBrokerPlugin.java > > > Due to the adding of the new properties to TimeStampingBrokerPlugin the "message.setTimestamp()" was misplaced and is set to early in the code. > The line need to be placed as the last line in the method send() as was in 5.2. > In addition the Plugin doesn't handle the scenario where the Broker is running "behind" its client. What is happening is that it's setting the Expiration and TimeStamp to historical values in the client perspective causing them to be discarded by the clients. > I have supplied a patch that solves both issues. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.