activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bruce Snyder <bruce.sny...@gmail.com>
Subject Re: [jira] Resolved: (AMQ-2368) it makes no sense for activemq-admin to load SUNJMX env var from /etc/activemq.conf
Date Sun, 13 Sep 2009 17:46:22 GMT
On Wed, Sep 9, 2009 at 7:32 AM, Dejan Bosanac (JIRA) <jira@apache.org> wrote:
>
>     [ https://issues.apache.org/activemq/browse/AMQ-2368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
>
> Dejan Bosanac resolved AMQ-2368.
> --------------------------------
>
>       Resolution: Fixed
>    Fix Version/s: 5.3.0
>         Assignee: Dejan Bosanac  (was: Rob Davies)
>
> Fixed with svn revision 812950. I also removed all activemq options such as dedicated
task runner and we don't really need 512 MB to run this stuff
>
>> it makes no sense for activemq-admin to load SUNJMX env var from /etc/activemq.conf
>> -----------------------------------------------------------------------------------
>>
>>                 Key: AMQ-2368
>>                 URL: https://issues.apache.org/activemq/browse/AMQ-2368
>>             Project: ActiveMQ
>>          Issue Type: Bug
>>          Components: JMX
>>    Affects Versions: 5.2.0, 5.3.0
>>            Reporter: Mats Henrikson
>>            Assignee: Dejan Bosanac
>>             Fix For: 5.3.0
>>
>>         Attachments: activemq-admin_reset_SUNJMX.patch
>>
>>
>> it doesn't make any sense for activemq-admin to load the SUNJMX env var from /etc/activemq.conf
since if activemq-admin is run on the same system that the broker runs on in many cases the
com.sun.management.jmxremote.port system property will be set in there. Since the activemq-admin
script now tries to use the same port that the broker is already using the script now fails
to run.
>> You could argue that there is no point for the activemq-script to even use the SUNJMX
variable at all, since there is little point in enabling a JMX connector for the script.
>> However in the attached patch all I've done is to reset the SUNJMX var so that it
doesn't use what is set in /etc/activemq.conf.


This issue was specifically regarding the SUNJMX variable. It had
nothing to do with removal of the ACTIVEMQ_OPTS variable from the
script startup. By removing the ACTIVEMQ_OPTS variable, now there is
an inconsistency between the activemq script and the activemq-admin
script. Additionally, I disagree with reducing the maximum amount of
memory given to the JVM. But I do agree that
UseDedicatedTaskRunner=true should not be used, though changing this
in an unrelated issue is not a good decision.

IMO, the change to the JVM max memory should be reversed. Nobody has
ever complained about it and it's a good middle ground for most
situations. Also, the change to remove the UseDedicatedTaskRunner=true
should take place in both the activemq and activemq-admin scripts but
via a separate issue.

Bruce
-- 
perl -e 'print unpack("u30","D0G)U8V4\@4VYY9&5R\"F)R=6-E+G-N>61E<D\!G;6%I;\"YC;VT*"
);'

ActiveMQ in Action: http://bit.ly/2je6cQ
Blog: http://bruceblog.org/
Twitter: http://twitter.com/brucesnyder

Mime
View raw message