activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gary Tully (JIRA)" <>
Subject [jira] Resolved: (AMQ-2305) TransportConnection Ignores isShutdownOnSlaveFailure
Date Fri, 26 Jun 2009 18:16:07 GMT


Gary Tully resolved AMQ-2305.

       Resolution: Fixed
    Fix Version/s: 5.3.0

Joe, it did not commit your patch as is, but changed the MasterBroker filter to not propagate
the stop request and just remove it's self. I think this is the correct thing to do in this
scenario as not stopping the MasterBroker filter will just ensure that it fails to sync with
the slave. The test case shows that this fix stops a plugin getting a stop request.

> TransportConnection Ignores isShutdownOnSlaveFailure
> ----------------------------------------------------
>                 Key: AMQ-2305
>                 URL:
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 5.2.0
>         Environment: ActiveMQ 5.2, Java 5, Windoze XP Pro 
>            Reporter: Joe Fernandez
>            Assignee: Gary Tully
>             Fix For: 5.3.0
>         Attachments: TransportConnection.patch
> In a pure Master/Slave configuration, when the slave fails the TransportConnection invokes
the MasterBroker's stop() method without taking into consideration the shutdownOnSlaveFailure
boolean, which by default is set to false.  So even if shutdownOnSlaveFailure  is set to false,
all my plugin brokers' stop methods get invoked when the slave fails.  

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message