Return-Path: 
 <dev-return-14232-apmail-activemq-dev-archive=activemq.apache.org@activemq.apache.org>
Delivered-To: apmail-activemq-dev-archive@www.apache.org
Received: (qmail 49376 invoked from network); 8 Feb 2009 14:53:27 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2)
  by minotaur.apache.org with SMTP; 8 Feb 2009 14:53:27 -0000
Received: (qmail 49697 invoked by uid 500); 8 Feb 2009 14:53:27 -0000
Delivered-To: apmail-activemq-dev-archive@activemq.apache.org
Received: (qmail 49677 invoked by uid 500); 8 Feb 2009 14:53:26 -0000
Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@activemq.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@activemq.apache.org>
List-Post: <mailto:dev@activemq.apache.org>
List-Id: <dev.activemq.apache.org>
Reply-To: dev@activemq.apache.org
Delivered-To: mailing list dev@activemq.apache.org
Received: (qmail 49666 invoked by uid 99); 8 Feb 2009 14:53:26 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 08 Feb 2009 06:53:26 -0800
X-ASF-Spam-Status: No, hits=-1998.5 required=10.0
	tests=ALL_TRUSTED,WEIRD_PORT
X-Spam-Check-By: apache.org
Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 08 Feb 2009 14:53:19 +0000
Received: from brutus (localhost [127.0.0.1])
	by brutus.apache.org (Postfix) with ESMTP id 968AF234C4B0
	for <dev@activemq.apache.org>; Sun,  8 Feb 2009 06:52:59 -0800 (PST)
Message-ID: <1964653305.1234104779615.JavaMail.jira@brutus>
Date: Sun, 8 Feb 2009 06:52:59 -0800 (PST)
From: "Swen Moczarski (JIRA)" <jira@apache.org>
To: dev@activemq.apache.org
Subject: [jira] Updated: (AMQ-1629) wildcards don't work in networkconnector
 excludeDestinations
In-Reply-To: <1723324272.1206025052635.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-Virus-Checked: Checked by ClamAV on apache.org


     [ https://issues.apache.org/activemq/browse/AMQ-1629?page=3Dcom.atlass=
ian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Swen Moczarski updated AMQ-1629:
--------------------------------

    Attachment: DemandForwardingBridgeFilterTest.java
                DemandForwardingBridgeSupport.java.patch

I see two problems with the current implementation (version 5.2)  for exclu=
ded- and dynamically-included destinations:

1. The type of the destination (queue, topic) is not distincted:
{code:xml}
<excludedDestinations> =E2=80=A8
   <topic physicalName=3D">"/> =E2=80=A8
</excludedDestinations>
{code}
Only topics should be excluded but all queues are also excluded.

2. An entry with a wildcard in the list has a side-effect on the following =
entries:
{code:xml}
<excludedDestinations>
   <queue physicalName=3D"exclude"/>
</excludedDestinations>
<dynamicallyIncludedDestinations>
   <queue physicalName=3D"foo.>"/>
   <queue physicalName=3D"bar.x"/>
</dynamicallyIncludedDestinations>
{code}=20
A message to {{bar.x}} will be blocked because of the wildcard in the first=
 entry.

I've created a test case and a new patch. I would be happy for a review of =
test case and patch.

> wildcards don't work in networkconnector excludeDestinations=20
> -------------------------------------------------------------
>
>                 Key: AMQ-1629
>                 URL: https://issues.apache.org/activemq/browse/AMQ-1629
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 4.1.1, 5.0.0
>         Environment: linux
>            Reporter: Sridhar Komandur
>            Assignee: Rob Davies
>             Fix For: 5.3.0
>
>         Attachments: amq1629.txt, DemandForwardingBridgeFilterTest.java, =
DemandForwardingBridgeSupport.java.patch
>
>
> Version: 5.0=20
> We have a simple setup to test excludedDestinations config ...We are usin=
g the broker and  example producer & consumer from the binary distribution =
(broker instances A & B are on different hosts=20
> Setup:=20
> producer --- A ---- B--- consumer=20
> Broker A's activemq.xml has the following for NC config (everythingelse i=
s the same as in the orig config file):
>     <networkConnectors>=20
>       <networkConnector name=3D"toB" uri=3D"static://(tcp://B.foo.com:616=
16)">=20
>            <excludedDestinations>=20
>                 <queue physicalName=3D"TEST.>" />=20
>            </excludedDestinations>=20
>      </networkConnector>=20
>     </networkConnectors>=20
> Issue: consumer attached to Broker B sees all the messages sent to TEST.F=
OO (the default messages generated by the producer)
> We noticed that none of the queue or topic wildcards work, only specific =
topic or queue names work in the exclusion. However, http://activemq.apache=
.org/networks-of-brokers.html states "N.B. You can use wildcards in inclusi=
ve , exclusive destination properties". Are we missing anything ?=20
> Thanks=20
> - Sridhar

--=20
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.